Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables

Lee Jones
2020-11-05T18:07:32Z

On Thu, 05 Nov 2020, Tomi Valkeinen wrote:

> On 05/11/2020 16:45, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’:
> > drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable]
> > drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’:
> > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable]
> > drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++-------
> > 1 file changed, 2 insertions(+), 7 deletions(-)
>
> I'd use "drm/omap: dsi: " subject prefix, the current one is fine too:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>
> Should I pick this up or do you want to keep the series intact?

If you are in a position to take it, please do so.

I rebase every day, so it will just vanish from my working set.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog