From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 221CCC4741F for ; Thu, 5 Nov 2020 18:14:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A6E920709 for ; Thu, 5 Nov 2020 18:14:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aoiHrPfJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732179AbgKESOq (ORCPT ); Thu, 5 Nov 2020 13:14:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732077AbgKESO2 (ORCPT ); Thu, 5 Nov 2020 13:14:28 -0500 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6A67C0613D2 for ; Thu, 5 Nov 2020 10:14:26 -0800 (PST) Received: by mail-il1-x143.google.com with SMTP id q1so2216432ilt.6 for ; Thu, 05 Nov 2020 10:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q46g2Y4Md6zeZcB0v/PCzPRQD2/DO2sEvtaycXsef+M=; b=aoiHrPfJtviJWxpB0JTShgx5+idh8ck62Xs+hABLTdURbuevfLTEvRtsyLebTs+/Hc Y8vAopVPwC6PMNtl0q0mt7LQaVvTdv67cwsKRqdgClNOyl0KKs+XYCLc4X5xxu4EWtgp 9OFy/cffEgYlAhqUENFc4wDDbYtXbLzUnytT4MjoYVgyh1ldnaOkh45oTDuulvftni0Q 3RpQGKHnteYd0S9z09MFoKVgjQmj+caGy6YKXOP9vE9y3uJMSmBvjY4jA/JY3gkcIYq9 tgSWMXdVExzdtlNyBLjM8GFHnRKbk0rJ2VSmRpue1AIxJOcu556qJdLNctvxFsjpK9DL YlOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q46g2Y4Md6zeZcB0v/PCzPRQD2/DO2sEvtaycXsef+M=; b=gAYxQ1m9AVRkG3HTiKuSiBIjS4QiNr3rbkqBxcTVUTCgnZZhP+vBcPgaCBjgUvi7qR AdWvf9WbA67mPDS1D6MzR8J1qIsKtgJX9Nqt4eN/EGg6PdJvQzsCTSJgsZszC+pSTVhN RImac7XEDDYRHVnnXMcItIWdrsGKSK4q/hiccNYD3WNGmMlVXl+8oamv4ghObrSSEj5x ku2RfS4Z6P8uVpgCWAKPtUP/O1K+D7btiC3ni/yStQvznyDOSH7cryOBQTvWOnoqTgsO sSHwB1/Aq+irFxrm+XskBYLnL3rNZjBdKHkljgcc2g9wbFN2ETqM8QmUgXtV2x/wC1sD HAMw== X-Gm-Message-State: AOAM533WTX4FWdRXlEOOIdRtT1Mg8S6cqOcmT8JQD5rh+Ew6WscUaDB7 DMSRgELfEHmCNWOMUC21XRAvOA== X-Google-Smtp-Source: ABdhPJyiaIVvYMPOI0rermK3dUd5lICYM6Jc4yylzvun/oYgwxnt0fkRt7l3FO0SbwmhuFjN2WbulA== X-Received: by 2002:a92:ca86:: with SMTP id t6mr2777842ilo.95.1604600066131; Thu, 05 Nov 2020 10:14:26 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id o19sm1554136ilt.24.2020.11.05.10.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 10:14:25 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 10/13] net: ipa: only enable GSI IEOB IRQs when needed Date: Thu, 5 Nov 2020 12:14:04 -0600 Message-Id: <20201105181407.8006-11-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201105181407.8006-1-elder@linaro.org> References: <20201105181407.8006-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A GSI channel must be started in order to use it to perform a transfer data (or command) transaction. And the only time we'll see an IEOB interrupt is if we send a transaction to a started channel. Therefore we do not need to have the IEOB interrupt type enabled until at least one channel has been started. And once the last started channel has been stopped, we can disable the IEOB interrupt type again. We already enable the IEOB interrupt for a particular channel only when it is started. Extend that by having the IEOB interrupt *type* be enabled only when at least one channel is in STARTED state. Disallow all channels from triggering the IEOB interrupt in gsi_irq_setup(). We only enable an channel's interrupt when needed, so there is no longer any need to zero the channel mask in gsi_irq_disable(). Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 4ab1d89f642ea..aae8ea852349d 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -258,6 +258,7 @@ static void gsi_irq_setup(struct gsi *gsi) iowrite32(0, gsi->virt + GSI_CNTXT_SRC_CH_IRQ_MSK_OFFSET); iowrite32(0, gsi->virt + GSI_CNTXT_SRC_EV_CH_IRQ_MSK_OFFSET); iowrite32(0, gsi->virt + GSI_CNTXT_GLOB_IRQ_EN_OFFSET); + iowrite32(0, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); } /* Turn off all GSI interrupts when we're all done */ @@ -269,11 +270,16 @@ static void gsi_irq_teardown(struct gsi *gsi) static void gsi_irq_ieob_enable(struct gsi *gsi, u32 evt_ring_id) { + bool enable_ieob = !gsi->ieob_enabled_bitmap; u32 val; gsi->ieob_enabled_bitmap |= BIT(evt_ring_id); val = gsi->ieob_enabled_bitmap; iowrite32(val, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); + + /* Enable the interrupt type if this is the first channel enabled */ + if (enable_ieob) + gsi_irq_type_enable(gsi, GSI_IEOB); } static void gsi_irq_ieob_disable(struct gsi *gsi, u32 evt_ring_id) @@ -281,6 +287,11 @@ static void gsi_irq_ieob_disable(struct gsi *gsi, u32 evt_ring_id) u32 val; gsi->ieob_enabled_bitmap &= ~BIT(evt_ring_id); + + /* Disable the interrupt type if this was the last enabled channel */ + if (!gsi->ieob_enabled_bitmap) + gsi_irq_type_disable(gsi, GSI_IEOB); + val = gsi->ieob_enabled_bitmap; iowrite32(val, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); } @@ -296,10 +307,6 @@ static void gsi_irq_enable(struct gsi *gsi) iowrite32(ERROR_INT_FMASK, gsi->virt + GSI_CNTXT_GLOB_IRQ_EN_OFFSET); gsi->type_enabled_bitmap |= BIT(GSI_GLOB_EE); - /* Each IEOB interrupt is enabled (later) as needed by channels */ - iowrite32(0, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); - gsi->type_enabled_bitmap |= BIT(GSI_IEOB); - /* We don't use inter-EE channel or event interrupts */ /* Never enable GSI_BREAK_POINT */ @@ -318,7 +325,6 @@ static void gsi_irq_disable(struct gsi *gsi) gsi_irq_type_update(gsi); iowrite32(0, gsi->virt + GSI_CNTXT_GSI_IRQ_EN_OFFSET); - iowrite32(0, gsi->virt + GSI_CNTXT_SRC_IEOB_IRQ_MSK_OFFSET); iowrite32(0, gsi->virt + GSI_CNTXT_GLOB_IRQ_EN_OFFSET); } -- 2.20.1