From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BC5C55179 for ; Fri, 6 Nov 2020 02:19:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7033220735 for ; Fri, 6 Nov 2020 02:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FvHlQ+Yf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725929AbgKFCTX (ORCPT ); Thu, 5 Nov 2020 21:19:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbgKFCTX (ORCPT ); Thu, 5 Nov 2020 21:19:23 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E538FC0613D3 for ; Thu, 5 Nov 2020 18:19:22 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id z24so2768657pgk.3 for ; Thu, 05 Nov 2020 18:19:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ThqwPvqZX83KmgF5BY1PefVZt9YcjzqlfmLEG4bvmlw=; b=FvHlQ+YfMPFzoBk5hdYiEqNTe/RaxVCprl/rfo+96/QbnAIiVe/LFGJLjRL065U/f0 v8t5kiTCi6Lz4CAFs30wgSyP1VYz+SpeCS/NzwdNM8WHXXSwpfs1E0OistQuyv6R95PS 0gsTngclvE0sgyXAN7tSMxE1Wv8PhBBY94yT4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ThqwPvqZX83KmgF5BY1PefVZt9YcjzqlfmLEG4bvmlw=; b=A0SNJsJWPQrCEo+JOcFOlP0IZ8+RB7NdqLH92V+wbXtMAw0D2aN/TLMAmD3G7gt6XM ePW3vY3JpTLHiS07g8GyxclrOs20SGG9d+Dk4A66HQAfcSNwyBCdaDq88paZUgDxw6tC 5i6+xgpsCVaHSW4UGE+9MtOHvO98Hb+kmh2bTm9OqNmJTcjE2rPiqXT2jA8V1k+h0Leb NxcffsSwe8rkkrQuPMCmcggGr4D2gS7U1oCaIa7WkxtEOAAlYpkVHflLSbPzJTqZHWFh rqUl+/HOMGNjgBLEOdquHsGwnsZJSnM4YmDd/OcL1vzTGBDzupNxtQ2HSl3HHfRuvylV g66w== X-Gm-Message-State: AOAM533yAInUBQ1P1aIP31xE2WPGTE5V7n1YwYwdUDwbiRtAuX8rZ88n vM3UrwxEda/EkeNi4zuvslOwMg== X-Google-Smtp-Source: ABdhPJwfRrkfR5rLKajUvQCxuRLHYyRA8tcQYEOUxq4EZD0w2cOHWxAPPzuDD2dndthCxI47EThnrA== X-Received: by 2002:a17:90a:c7c3:: with SMTP id gf3mr5367076pjb.140.1604629162354; Thu, 05 Nov 2020 18:19:22 -0800 (PST) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id j13sm4045356pfd.97.2020.11.05.18.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 18:19:21 -0800 (PST) Date: Thu, 5 Nov 2020 18:19:20 -0800 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7180-trogdor: Make pp3300_a the default supply for pp3300_hub Message-ID: <20201106021920.GB4128558@google.com> References: <20201105163724.v2.1.I5a75056d573808f40fed22ab7d28ea6be5819f84@changeid> <20201105163724.v2.2.I0ed4abdd2b2916fbedf76be254bc3457fb8b9655@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2020 at 05:05:38PM -0800, Doug Anderson wrote: > Hi, > > On Thu, Nov 5, 2020 at 4:37 PM Matthias Kaehlcke wrote: > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts > > index 0a281c24841c..6603f2102233 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts > > @@ -58,10 +58,23 @@ ap_ts: touchscreen@10 { > > }; > > }; > > > > +&pp3300_hub { > > + /* pp3300_l7c is used to power the USB hub */ > > + /delete-property/regulator-always-on; > > +}; > > + > > +&pp3300_l7c { > > + regulator-always-on; > > Personally I always end up pairing "always-on" and "boot-on", but that > might just be superstition from many kernel versions ago when there > were weird quirks. The way you have it now you will sometimes have > "boot-on" but not "always-on". Probably what you have is fine, > though. You are right, it makes a certain sense to have them paired, I'll change it even though it leads to a few more entries. > > +}; > > + > > &sdhc_2 { > > status = "okay"; > > }; > > > > +&usb_hub { > > + vdd-supply = <&pp3300_l7c>; > > +}; > > + > > /* PINCTRL - board-specific pinctrl */ > > > > &tlmm { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > index bf875589d364..50e733412a7f 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > @@ -174,6 +174,25 @@ pp3300_fp_tp: pp3300-fp-tp-regulator { > > vin-supply = <&pp3300_a>; > > }; > > > > + pp3300_hub: pp3300-hub { > > + compatible = "regulator-fixed"; > > + regulator-name = "pp3300_hub"; > > + > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + > > + gpio = <&tlmm 84 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&en_pp3300_hub>; > > + > > + /* AP turns on with en_pp3300_hub; always on for AP */ > > Delete the above comment. It's obvious based on the properties in > this node. Other similar comments are useful because they describe > how the _EC_ turns on regulators and why a regulator that has an > enable still looks like an "always-on" regulator to the AP (because > it's always on whenever the AP is on). > > If you want to add a comment, you could say: > > /* Always on until we have a way to specify it can go off in suspend */ ok > > @@ -469,7 +488,6 @@ ppvar_l6c: ldo6 { > > regulator-initial-mode = ; > > }; > > > > - pp3300_hub: > > pp3300_l7c: ldo7 { > > regulator-min-microvolt = <3304000>; > > regulator-max-microvolt = <3304000>; > > Shouldn't you delete the "regulator-always-on;" from ldo7 since you're > adding it for all the older revs? Indeed, that was the intention, it didn't blow up into my face during testing since the downstream tree doesn't have it anymore.