public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com, irogers@google.com
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Date: Fri, 6 Nov 2020 12:00:18 +0900	[thread overview]
Message-ID: <20201106030018.GA359712@google.com> (raw)
In-Reply-To: <20201104015102.30363-1-yao.jin@linux.intel.com>

Hi,

On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote:
> - Update Skylake events to v50.
> - Update Skylake JSON metrics from TMAM 4.0.
> - Fix the issue in DRAM_Parallel_Reads
> - Fix the perf test warning
> 
> Before:
> 
> root@kbl-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1
> event syntax error: '{arb/event=0x80,umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>                      \___ unknown term 'thresh' for pmu 'uncore_arb'
> 
> valid terms: event,edge,inv,umask,cmask,config,config1,config2,name,period,percore
> 
> Initial error:
> event syntax error: '..umask=0x2/,arb/event=0x80,umask=0x2,thresh=1/}:W'
>                                   \___ Cannot find PMU `arb'. Missing kernel support?
> 
> root@kbl-ppc:~# perf test metrics
> 10: PMU events                                 :
> 10.3: Parsing of PMU event table metrics               : Skip (some metrics failed)
> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> 67: Parse and process metrics                  : Ok
> 
> After:
> 
> root@kbl-ppc:~# perf stat -M MEM_Parallel_Reads -- sleep 1
> 
>  Performance counter stats for 'system wide':
> 
>          4,951,646      arb/event=0x80,umask=0x2/ #    26.30 MEM_Parallel_Reads       (50.04%)
>            188,251      arb/event=0x80,umask=0x2,cmask=1/                                     (49.96%)
> 
>        1.000867010 seconds time elapsed
> 
> root@kbl-ppc:~# perf test metrics
> 10: PMU events                                 :
> 10.3: Parsing of PMU event table metrics               : Ok
> 10.4: Parsing of PMU event table metrics with fake PMUs: Ok
> 67: Parse and process metrics                  : Ok
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>

It seems not applied to acme/perf/core cleanly.

Thanks,
Namhyung

  reply	other threads:[~2020-11-06  3:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  1:51 [PATCH] perf vendor events: Update Skylake client events to v50 Jin Yao
2020-11-06  3:00 ` Namhyung Kim [this message]
2020-11-06  3:11   ` Jin, Yao
2020-11-06  4:21     ` Namhyung Kim
2020-11-13  8:12       ` Jin, Yao
2020-11-15 13:35         ` Andi Kleen
     [not found]           ` <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>
2020-11-16  8:07             ` Jin, Yao
2020-11-16 14:53             ` Andi Kleen
2020-11-16 17:05       ` Arnaldo Carvalho de Melo
     [not found]         ` <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
2020-11-16 19:24           ` Arnaldo Carvalho de Melo
2020-11-16 21:24             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201106030018.GA359712@google.com \
    --to=namhyung@kernel.org \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox