From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wang Qing <wangqing@vivo.com>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: Use IS_ERR_OR_NULL() instead of IS_ERR()
Date: Fri, 6 Nov 2020 07:52:17 +0100 [thread overview]
Message-ID: <20201106065217.GE697514@kroah.com> (raw)
In-Reply-To: <1604633478-24729-1-git-send-email-wangqing@vivo.com>
On Fri, Nov 06, 2020 at 11:31:18AM +0800, Wang Qing wrote:
> __usb_find_phy may return NULL, so we should use IS_ERR_OR_NULL()
Again with the subject line, "USB: phy: ..." And are you sure this
function can return NULL?
thanks,
greg k-h
prev parent reply other threads:[~2020-11-06 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 3:31 [PATCH] usb: Use IS_ERR_OR_NULL() instead of IS_ERR() Wang Qing
2020-11-06 6:52 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106065217.GE697514@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox