From: "Pali Rohár" <pali@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Marek Behun <marek.behun@nic.cz>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Terry Zhou <bjzhou@marvell.com>,
Konstantin Porotchkin <kostap@marvell.com>
Subject: [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9
Date: Fri, 6 Nov 2020 11:00:39 +0100 [thread overview]
Message-ID: <20201106100039.11385-1-pali@kernel.org> (raw)
From: Terry Zhou <bjzhou@marvell.com>
There is an error in the current code that the XTAL MODE
pin was set to NB MPP1_31 which should be NB MPP1_9.
The latch register of NB MPP1_9 has different offset of 0x8.
Signed-off-by: Terry Zhou <bjzhou@marvell.com>
[pali: Fix pin name in commit message]
Signed-off-by: Pali Rohár <pali@kernel.org>
Fixes: 7ea8250406a6 ("clk: mvebu: Add the xtal clock for Armada 3700 SoC")
Cc: stable@vger.kernel.org
---
This patch is present in Marvell SDK and also in Marvell's kernel fork:
https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/80d4cec4cef8282e5ac3aaf98ce3e68fb299a134
Konstantin Porotchkin wrote on Github that Gregory Clement was notified
about this patch, but as this patch is still not in mainline kernel I'm
sending it again for review.
In original commit message (only in commit message, not code) was
specified MPP9 pin on South Bridge, but correct is North Bridge.
---
drivers/clk/mvebu/armada-37xx-xtal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/mvebu/armada-37xx-xtal.c b/drivers/clk/mvebu/armada-37xx-xtal.c
index e9e306d4e9af..41271351cf1f 100644
--- a/drivers/clk/mvebu/armada-37xx-xtal.c
+++ b/drivers/clk/mvebu/armada-37xx-xtal.c
@@ -13,8 +13,8 @@
#include <linux/platform_device.h>
#include <linux/regmap.h>
-#define NB_GPIO1_LATCH 0xC
-#define XTAL_MODE BIT(31)
+#define NB_GPIO1_LATCH 0x8
+#define XTAL_MODE BIT(9)
static int armada_3700_xtal_clock_probe(struct platform_device *pdev)
{
--
2.20.1
next reply other threads:[~2020-11-06 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 10:00 Pali Rohár [this message]
2020-11-06 10:51 ` [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9 Marek Behún
2020-11-13 10:19 ` Pali Rohár
2020-12-01 9:46 ` Pali Rohár
2020-12-19 23:51 ` Stephen Boyd
2020-12-20 16:21 ` Pali Rohár
2020-12-21 1:47 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106100039.11385-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=bjzhou@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=kostap@marvell.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox