From: Greg KH <gregkh@linuxfoundation.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Arpitha Raghunandan <98.arpi@gmail.com>,
Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
brendanhiggins@google.com, skhan@linuxfoundation.org,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
alexandre.belloni@bootlin.com, rdunlap@infradead.org,
idryomov@gmail.com, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3] lib: Convert test_printf.c to KUnit
Date: Fri, 6 Nov 2020 11:42:03 +0100 [thread overview]
Message-ID: <20201106104203.GC2784089@kroah.com> (raw)
In-Reply-To: <1b452380-53a5-f396-bf2f-97736db28afb@rasmusvillemoes.dk>
On Fri, Nov 06, 2020 at 11:31:43AM +0100, Rasmus Villemoes wrote:
> On 06/11/2020 05.04, Arpitha Raghunandan wrote:
> >
> > The total number of "atoms" can be printed by maintaining a static variable
> > total_count that can be incremented as is in the original test_printf test.
> > But, the reporting of the random seed currently is done in kselftest and so
> > will not show up with KUnit. I am not really sure which is better in this case.
>
> So my real questions are: Why do we have both kselftest and kunit?
One is testing code within the kernel image testing it within
kernelspace, and one is outside the kernel testing it from userspace.
thanks,
greg k-h
prev parent reply other threads:[~2020-11-06 10:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:10 [PATCH v3] lib: Convert test_printf.c to KUnit Arpitha Raghunandan
2020-11-03 11:33 ` Andy Shevchenko
2020-11-03 11:52 ` Greg KH
2020-11-03 12:06 ` Andy Shevchenko
2020-11-03 12:18 ` Greg KH
2020-11-03 16:11 ` Petr Mladek
2020-11-03 16:23 ` Greg KH
2020-11-03 17:38 ` Brendan Higgins
2020-11-04 8:18 ` Rasmus Villemoes
2020-11-06 4:04 ` Arpitha Raghunandan
2020-11-06 10:31 ` Rasmus Villemoes
2020-11-06 10:42 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106104203.GC2784089@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=98.arpi@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=idryomov@gmail.com \
--cc=keescook@chromium.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox