From: Joel Fernandes <joel@joelfernandes.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Marco Elver <elver@google.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
rcu@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>,
fweisbec@gmail.com, neeraj.iitr10@gmail.com
Subject: Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include
Date: Fri, 6 Nov 2020 19:27:00 -0500 [thread overview]
Message-ID: <20201107002700.GB3144506@google.com> (raw)
In-Reply-To: <20201105142810.GA16800@paulmck-ThinkPad-P72>
On Thu, Nov 05, 2020 at 06:28:10AM -0800, Paul E. McKenney wrote:
> On Wed, Nov 04, 2020 at 07:48:23PM -0800, Paul E. McKenney wrote:
> > On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote:
> > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> >
> > This one looks fine, but depends on the earlier "rcu/segcblist: Add
> > counters to segcblist datastructure" patch, which also changes the list
> > of #include directives for this file. It manages to avoid conflicting
> > with "rcu/trace: Add tracing for how segcb list changes", despite this
> > one also changing the #include directives.
> >
> > I am testing it just out of curiosity, but it might make more sense
> > to fold this one into "rcu/segcblist: Add counters to segcblist
> > datastructure".
>
> And it does pass light rcutorture. ;-)
Cool, I squashed it into 2/7 and updated my tree.
thanks,
- Joel
> Thanx, Paul
>
> > > ---
> > > kernel/rcu/rcu_segcblist.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> > > index 2a03949d0b82..e9e72d72f7a6 100644
> > > --- a/kernel/rcu/rcu_segcblist.c
> > > +++ b/kernel/rcu/rcu_segcblist.c
> > > @@ -10,7 +10,6 @@
> > > #include <linux/cpu.h>
> > > #include <linux/interrupt.h>
> > > #include <linux/kernel.h>
> > > -#include <linux/rcupdate.h>
> > > #include <linux/types.h>
> > >
> > > #include "rcu_segcblist.h"
> > > --
> > > 2.29.1.341.ge80a0c044ae-goog
> > >
next prev parent reply other threads:[~2020-11-07 0:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:25 [PATCH v9 0/7] Add support for length of each segment in the segcblist Joel Fernandes (Google)
2020-11-03 14:25 ` [PATCH v9 1/7] rcu/tree: Make rcu_do_batch count how many callbacks were executed Joel Fernandes (Google)
2020-11-04 0:05 ` Paul E. McKenney
2020-11-04 15:09 ` Joel Fernandes
2020-11-03 14:25 ` [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure Joel Fernandes (Google)
2020-11-04 13:37 ` Neeraj Upadhyay
2020-11-04 17:01 ` Paul E. McKenney
2020-11-07 0:01 ` Joel Fernandes
2020-11-07 0:18 ` Joel Fernandes
2020-11-07 0:48 ` Paul E. McKenney
2020-11-10 1:39 ` Paul E. McKenney
2020-11-03 14:25 ` [PATCH v9 3/7] srcu: Fix invoke_rcu_callbacks() segcb length adjustment Joel Fernandes (Google)
2020-11-03 14:47 ` Frederic Weisbecker
2020-11-03 14:56 ` Joel Fernandes
2020-11-03 15:07 ` Joel Fernandes
2020-11-03 15:18 ` Paul E. McKenney
2020-11-03 15:19 ` Frederic Weisbecker
2020-11-04 13:37 ` Neeraj Upadhyay
2020-11-03 14:26 ` [PATCH v9 4/7] rcu/trace: Add tracing for how segcb list changes Joel Fernandes (Google)
2020-11-03 15:17 ` Frederic Weisbecker
2020-11-04 14:08 ` Paul E. McKenney
2020-11-04 14:33 ` Frederic Weisbecker
2020-11-07 0:05 ` Joel Fernandes
2020-11-04 13:40 ` Neeraj Upadhyay
2020-11-04 15:05 ` Joel Fernandes
2020-11-11 0:35 ` Paul E. McKenney
2020-11-11 13:49 ` Steven Rostedt
2020-11-11 14:08 ` Joel Fernandes
2020-11-03 14:26 ` [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include Joel Fernandes (Google)
2020-11-05 3:48 ` Paul E. McKenney
2020-11-05 14:28 ` Paul E. McKenney
2020-11-07 0:27 ` Joel Fernandes [this message]
2020-11-03 14:26 ` [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s Joel Fernandes (Google)
2020-11-05 3:57 ` Paul E. McKenney
2020-11-07 0:26 ` Joel Fernandes
2020-11-10 1:41 ` Paul E. McKenney
2020-11-03 14:26 ` [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb() Joel Fernandes (Google)
2020-11-05 18:55 ` Paul E. McKenney
2020-11-06 22:41 ` Joel Fernandes
2020-11-10 1:28 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201107002700.GB3144506@google.com \
--to=joel@joelfernandes.org \
--cc=elver@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=neeraj.iitr10@gmail.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox