From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07306C388F9 for ; Sun, 8 Nov 2020 10:12:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9C0C206F4 for ; Sun, 8 Nov 2020 10:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728302AbgKHKMc (ORCPT ); Sun, 8 Nov 2020 05:12:32 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:48388 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgKHKMc (ORCPT ); Sun, 8 Nov 2020 05:12:32 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CECD3804F6; Sun, 8 Nov 2020 11:12:28 +0100 (CET) Date: Sun, 8 Nov 2020 11:12:27 +0100 From: Sam Ravnborg To: Peter Ujfalusi Cc: hyun.kwon@xilinx.com, laurent.pinchart@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: xlnx: Use dma_request_chan for DMA channel request Message-ID: <20201108101227.GD1129714@ravnborg.org> References: <20201023094602.5630-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023094602.5630-1-peter.ujfalusi@ti.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VafZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=sozttTNsAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=4ucCiA6Z2YONicSglYkA:9 a=CjuIK1q_8ugA:10 a=aeg5Gbbo78KNqacMgKqU:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter. On Fri, Oct 23, 2020 at 12:46:02PM +0300, Peter Ujfalusi wrote: > There is no need to use the of_dma_request_slave_channel() directly as > dma_request_chan() is going to try to get the channel via OF as well. > > Signed-off-by: Peter Ujfalusi I took a look at this and agree on your analysis. Reviewed-by: Sam Ravnborg I expect the maintainers to pick up this patch. Sam > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 98bd48f13fd1..a4405d081aca 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -28,7 +28,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -1316,8 +1315,7 @@ static int zynqmp_disp_layer_request_dma(struct zynqmp_disp *disp, > > snprintf(dma_channel_name, sizeof(dma_channel_name), > "%s%u", dma_names[layer->id], i); > - dma->chan = of_dma_request_slave_channel(disp->dev->of_node, > - dma_channel_name); > + dma->chan = dma_request_chan(disp->dev, dma_channel_name); > if (IS_ERR(dma->chan)) { > dev_err(disp->dev, "failed to request dma channel\n"); > ret = PTR_ERR(dma->chan); > -- > Peter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel