Re: [PATCH 00/20] [Set 1/2] Rid W=1 issues from Input

Lee Jones
2020-11-06T13:24:31Z

On Wed, 04 Nov 2020, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is the first of 2 sets.
>
> Lee Jones (20):
> input: rmi4: rmi_bus: Fix misnaming of
> '__rmi_register_function_handler's 'owner' param
> input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
> input: mouse: cyapa_gen5: Fix obvious abuse of kernel-doc format
> input: misc: ab8500-ponkey: Fix incorrect name in 'ab8500_ponkey' doc
> header
> input: rmi4: rmi_f01: Struct headers are expected to start with
> 'struct <name>'
> include: input: elan-i2c-ids: Mark 'elan_acpi_id' as __maybe_unused
> input: keyboard: cros_ec_keyb: Struct headers should start with
> 'struct <name>'
> input: rmi4: rmi_f11: Struct headers are expected to start with
> 'struct <name>'
> input: touchscreen: resistive-adc-touch: Struct headers should start
> with 'struct <name>'
> input: mouse: synaptics: Place braces around empty if() body
> input: keyboard: gpio_keys: Fix misnamed function parameter 'dev'
> input: mouse: elantech: Demote obvious abuse of kernel-doc header
> input: rmi4: rmi_f54: Provide some missing 'REPORT_TYPE' enums
> input: rmi4: rmi_i2c: Provide some missing descriptions for struct
> members
> input: touchscreen: cyttsp4_core: Move 'cyttsp4_tch_abs_string' to
> the only file that references it
> input: misc: drv260x: Fix kernel-doc formatting and remove one abuse
> input: misc: drv2665: Fix formatting expected by kernel-doc
> input: misc: drv2667: Fix formatting and add missing member docs
> input: keyboard: nomadik-ske-keypad: Provide some missing struct
> member docs
> input: keyboard: pmic8xxx-keypad: Fix kernel-doc formatting

Dmitry,

Seeing as these changes are orthogonal, it would probably be easier
and certainly cause a lot less mailing list churn if you would be kind
enough to apply patches that do not need re-spinning.

I will rebase, rework and re-submit the remainder early next week.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog