From: Christoph Hellwig <hch@infradead.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: export device_is_bound() to fix build failure
Date: Mon, 9 Nov 2020 08:19:46 +0000 [thread overview]
Message-ID: <20201109081946.GA7720@infradead.org> (raw)
In-Reply-To: <20201106153744.22661-1-sudipm.mukherjee@gmail.com>
On Fri, Nov 06, 2020 at 03:37:44PM +0000, Sudip Mukherjee wrote:
> When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> is unable to find device_is_bound(). The error being:
> ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> undefined!
>
> Export the symbol so that the module finds it.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> drivers/base/dd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 148e81969e04..a796a57e5efb 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
> {
> return dev->p && klist_node_attached(&dev->p->knode_driver);
> }
> +EXPORT_SYMBOL(device_is_bound);
Everything else in this file uses EXPORT_SYMBOL_GPL, so I don't see why
this would be special.
That being said a good rationale of why it is a good idea to use this in
drivers is also required.
prev parent reply other threads:[~2020-11-09 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 15:37 [PATCH] driver core: export device_is_bound() to fix build failure Sudip Mukherjee
2020-11-07 9:21 ` Greg Kroah-Hartman
2020-11-09 8:19 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109081946.GA7720@infradead.org \
--to=hch@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox