From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F63C2D0A3 for ; Mon, 9 Nov 2020 10:53:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54F5B20679 for ; Mon, 9 Nov 2020 10:53:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729470AbgKIKxx (ORCPT ); Mon, 9 Nov 2020 05:53:53 -0500 Received: from mga14.intel.com ([192.55.52.115]:47402 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgKIKxx (ORCPT ); Mon, 9 Nov 2020 05:53:53 -0500 IronPort-SDR: kZjDxM7EyUyJf0E1UIRyTIGe+g8yF65biy7y0ZOQtrLYXuzSSqkiCpYMoaOOb5sKfgtZkBE1M6 3vyZ+x3TPFKA== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="168998713" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="168998713" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:53:48 -0800 IronPort-SDR: NTCpmKnf5EdAo+iIXcsujuo6fkf3g4ItRHgCV/UPeGyFvVhap4eGgt/oUyTEx4IvsQ0JiLYPcf Db1hWDEeRvqw== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="327228204" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:53:47 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kc4oz-0059eK-3s; Mon, 09 Nov 2020 12:54:49 +0200 Date: Mon, 9 Nov 2020 12:54:49 +0200 From: Andy Shevchenko To: Jiri Slaby Cc: David Laight , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH v1 1/3] vt: keyboard, use GENMAASK()/BIT() macros instead of open coded variants Message-ID: <20201109105449.GX4077@smile.fi.intel.com> References: <20201106143551.43908-1-andriy.shevchenko@linux.intel.com> <56794a31-26ed-39eb-4082-75b5ec7cf28a@kernel.org> <20201109102759.GT4077@smile.fi.intel.com> <0bbc9282-3655-26f3-468f-4dccd7ded741@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0bbc9282-3655-26f3-468f-4dccd7ded741@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 11:41:31AM +0100, Jiri Slaby wrote: > On 09. 11. 20, 11:27, Andy Shevchenko wrote: > > On Mon, Nov 09, 2020 at 12:10:27PM +0200, Andy Shevchenko wrote: > > > On Mon, Nov 9, 2020 at 11:57 AM Jiri Slaby wrote: > > > > On 06. 11. 20, 17:06, Andy Shevchenko wrote: > > > > ... > > > > > > sorry, > > > > > > Consider this then as RFC. > > > What about the rest of the series? > > > > I got the answer, thanks! > > So, I will drop the first patch and resend the rest with your Ack. > > As I wrote the BIT pieces are mostly fine too… Okay, I will try again with BIT() conversion only. -- With Best Regards, Andy Shevchenko