From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537E7C2D0A3 for ; Mon, 9 Nov 2020 11:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD62A206B6 for ; Mon, 9 Nov 2020 11:41:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604922088; bh=HGqNgTmS0U40pm39xZrWRkCSImvX6c6OezTYr8uPL8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=PIJebPRCjYxApaPwnMVSCuoDlNbk8/HOrnS9sCIePpBcMwwET8BSKcJ9pYw6QOeWj yQHYhCbRTk2PeM7AgE5mqT5NQfFQeczyy5y2wd83XSq+Z3wSkUaSdARJVEMCqsXh52 +yVd5nkE+h+uLirv+iUorDrPbAZMNOozoSFid1tU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729645AbgKILl1 (ORCPT ); Mon, 9 Nov 2020 06:41:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:33872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729320AbgKILl0 (ORCPT ); Mon, 9 Nov 2020 06:41:26 -0500 Received: from localhost (unknown [122.171.147.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 051A820684; Mon, 9 Nov 2020 11:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604922086; bh=HGqNgTmS0U40pm39xZrWRkCSImvX6c6OezTYr8uPL8U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ot9e5LHp1yebv2QTG3Zmke/D6BMZhYJckqyI/gNVz1LnVOW6MaxZJZ7pLfw28GPUJ 0R5JQSc1VvhqC6wz5lc0QyY6U6bRqf5IdunqLlrOv1+zzq1OZi3srDix7x7hJ/cRRR eJ5MJtIzAyifbrxJdC7dGHn9UkxbRDfB892RDipI= Date: Mon, 9 Nov 2020 17:11:21 +0530 From: Vinod Koul To: Jonathan McDowell Cc: Andy Gross , Bjorn Andersson , Dan Williams , Philipp Zabel , Thomas Pedersen , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v4] dmaengine: qcom: Add ADM driver Message-ID: <20201109114121.GG3171@vkoul-mobl> References: <20200916064326.GA13963@earth.li> <20200919185739.GS3411@earth.li> <20200920181204.GT3411@earth.li> <20200923194056.GY3411@earth.li> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200923194056.GY3411@earth.li> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Jonathan, On 23-09-20, 20:40, Jonathan McDowell wrote: > Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA > controller found in the MSM8x60 and IPQ/APQ8064 platforms. Mostly it looks good, some nitpicks > The ADM supports both memory to memory transactions and memory > to/from peripheral device transactions. The controller also provides > flow control capabilities for transactions to/from peripheral devices. > > The initial release of this driver supports slave transfers to/from > peripherals and also incorporates CRCI (client rate control interface) > flow control. Can you also convert the binding from txt to yaml? > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > index 3bcb689162c6..0389d60d2604 100644 > --- a/drivers/dma/qcom/Kconfig > +++ b/drivers/dma/qcom/Kconfig > @@ -1,4 +1,15 @@ > # SPDX-License-Identifier: GPL-2.0-only > +config QCOM_ADM > + tristate "Qualcomm ADM support" > + depends on (ARCH_QCOM || COMPILE_TEST) && !PHYS_ADDR_T_64BIT why !PHYS_ADDR_T_64BIT ..? > + select DMA_ENGINE > + select DMA_VIRTUAL_CHANNELS > + help > + Enable support for the Qualcomm Application Data Mover (ADM) DMA > + controller, as present on MSM8x60, APQ8064, and IPQ8064 devices. > + This controller provides DMA capabilities for both general purpose > + and on-chip peripheral devices. > +static const struct of_device_id adm_of_match[] = { > + { .compatible = "qcom,adm", }, I know we have merged the binding, but should we not have a soc specific compatible? -- ~Vinod