From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3201C388F7 for ; Mon, 9 Nov 2020 13:33:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FAD2206ED for ; Mon, 9 Nov 2020 13:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604928810; bh=a4fewJNY0TNNf/IBkSpKcRWKjiib/2IG8c/d6vocP8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ByZ2jaYPWK5uz1/16Kva5UWZd0JapM4XLTDydijp/Db8aOKfQHhHLPyBI8pT+4n4d scUqX6xOmmrqutEfH4RjVHA6wpQZbJgAHTRCFU5yrnfVAP07Nda7UVCA1YFK7H/Ldt sY+lNHpwz2nEgirQi8D25139vtnb72PEodFr16ic= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731991AbgKINd3 (ORCPT ); Mon, 9 Nov 2020 08:33:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:59412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731113AbgKINGl (ORCPT ); Mon, 9 Nov 2020 08:06:41 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C03E520789; Mon, 9 Nov 2020 13:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927201; bh=a4fewJNY0TNNf/IBkSpKcRWKjiib/2IG8c/d6vocP8E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h4tOIWWl1Swwko14kLBCr2limz4szF7lK+lKO7PIM9hqlDLvUdeFiOdLFz6G/jR2a ByaL+n5VMraxCo2ZwUF+C+Xl32HmyTYPvz2s7TpjRv3RHjcVITaZYTIaNsQwba76RR P6ArZLS5pXG2IX5vCso4Csilj8iJSDW223jn1S8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Andrew Lunn , Jakub Kicinski Subject: [PATCH 4.14 08/48] sfp: Fix error handing in sfp_probe() Date: Mon, 9 Nov 2020 13:55:17 +0100 Message-Id: <20201109125017.154511467@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125016.734107741@linuxfoundation.org> References: <20201109125016.734107741@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 9621618130bf7e83635367c13b9a6ee53935bb37 ] gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -881,7 +881,8 @@ static int sfp_probe(struct platform_dev continue; irq = gpiod_to_irq(sfp->gpio[i]); - if (!irq) { + if (irq < 0) { + irq = 0; poll = true; continue; }