From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB97C2D0A3 for ; Mon, 9 Nov 2020 13:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24B522065D for ; Mon, 9 Nov 2020 13:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604928778; bh=+qzEpUJCxxfNzA2GNjkjNiRKONZh93YWfqAcks8ltew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=y4vUFdrPXAXpYSSpVa07/gvhjaCfg57WwWBUMbjgvrlUW86VcRNdPyLfbnokWjg64 NQ+zdFmOAjL5FOgp74YIym4IWbADThxMSY59CX1C3W+9hE1O1ec8KJ2XEK1ejm/EaP BXgIZCNm/Ff1XUOkLc6ZeNfihMqBQvenxmiYLJCc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732072AbgKINc5 (ORCPT ); Mon, 9 Nov 2020 08:32:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:59666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731177AbgKING4 (ORCPT ); Mon, 9 Nov 2020 08:06:56 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A431420663; Mon, 9 Nov 2020 13:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927216; bh=+qzEpUJCxxfNzA2GNjkjNiRKONZh93YWfqAcks8ltew=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GD3LK4UAjuw1kkVbeiPUPj4qfyVScBCsTnqMyHMP+Yy746xhUrL5V5hVtzbwT35Ev dHotuhIH9q1mt0BU4jO23rEqVsz8AjRVkHR/kjOTUWD39OZc83anhJq5nrZV7J7Uuh /SplHNKuuWv0HcgFq2IwkAdMqq6vH+/7Q0u6CuXA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hoegeun Kwon , Maxime Ripard , Sasha Levin Subject: [PATCH 4.14 33/48] drm/vc4: drv: Add error handding for bind Date: Mon, 9 Nov 2020 13:55:42 +0100 Message-Id: <20201109125018.394374851@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125016.734107741@linuxfoundation.org> References: <20201109125016.734107741@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 1c96edcb302be..028dc2819a368 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -283,6 +283,7 @@ static int vc4_drm_bind(struct device *dev) component_unbind_all(dev, drm); gem_destroy: vc4_gem_destroy(drm); + drm_mode_config_cleanup(drm); vc4_bo_cache_destroy(drm); dev_unref: drm_dev_unref(drm); -- 2.27.0