From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27835C2D0A3 for ; Mon, 9 Nov 2020 13:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB46F221F9 for ; Mon, 9 Nov 2020 13:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927516; bh=jMWe8OZ+/f+WCGiHMjeMTOQFuIzD5XxpUKyXGGpK/fM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=MoVV4GPDcUZqb6TdBm70n4jXzYGhp2PxmaP19hL/z+AIq6W9wg1TcW2h4p73ECn4J //GMLM2Db5/6gocVmeRPpgEqs4DQkzGUhiRiWjdkcEEePycutv/jRnGNyxkKk3Jq8V I4vZtvh1cNtakMcJnk/LOiqRwZBO5hkbi4dpzCTo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732481AbgKINLz (ORCPT ); Mon, 9 Nov 2020 08:11:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:37392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732457AbgKINLu (ORCPT ); Mon, 9 Nov 2020 08:11:50 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A225920789; Mon, 9 Nov 2020 13:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927510; bh=jMWe8OZ+/f+WCGiHMjeMTOQFuIzD5XxpUKyXGGpK/fM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IYUbY3dGSODpLZbcAGncGLqLEGdA0vjsFRxpuD7TnTpMBhuybiTtKcxqnJd3suXfQ e13kX/ZK5t1HeH4fGNP5fl2Sc44x+DvGpqb6HcAVH4oHqi75/jnC+FSqmDwSdZH2/p eSeYD6CqX3aln3+jk4seoePh4mwzeNmMiWBfqG9E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vinay Kumar Yadav , Jakub Kicinski Subject: [PATCH 5.4 13/85] chelsio/chtls: fix always leaking ctrl_skb Date: Mon, 9 Nov 2020 13:55:10 +0100 Message-Id: <20201109125023.224434105@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125022.614792961@linuxfoundation.org> References: <20201109125022.614792961@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vinay Kumar Yadav [ Upstream commit dbfe394dad33f99cf8458be50483ec40a5d29c34 ] Correct skb refcount in alloc_ctrl_skb(), causing skb memleak when chtls_send_abort() called with NULL skb. it was always leaking the skb, correct it by incrementing skb refs by one. Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition") Signed-off-by: Vinay Kumar Yadav Link: https://lore.kernel.org/r/20201102173909.24826-1-vinay.yadav@chelsio.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/chelsio/chtls/chtls_cm.c +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c @@ -174,7 +174,7 @@ static struct sk_buff *alloc_ctrl_skb(st { if (likely(skb && !skb_shared(skb) && !skb_cloned(skb))) { __skb_trim(skb, 0); - refcount_add(2, &skb->users); + refcount_inc(&skb->users); } else { skb = alloc_skb(len, GFP_KERNEL | __GFP_NOFAIL); }