From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE2F2C4741F for ; Mon, 9 Nov 2020 13:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A98A20789 for ; Mon, 9 Nov 2020 13:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927540; bh=uBQpzeg9/W69UMZEoNOlR4jrZDydp8HudzXQWnZs5nU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yUjlbnsiVCfIzM2Pj4fXoQGkX+2oadrX1lW5nmr8+CGbpGSRfP0SnPGrlQ/iuMptK 4MEUlgaOCjWMUChJiX1Vm7TwVVa0OJ+FEMtbLVVPxlvW/mrW4W0gW30r+/ru25EjLh 7oWM4kXZRTjdk7ZyQnMNtU4gG5pYk0dUPq/6Bzh4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732579AbgKINMT (ORCPT ); Mon, 9 Nov 2020 08:12:19 -0500 Received: from mail.kernel.org ([198.145.29.99]:37840 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731754AbgKINMR (ORCPT ); Mon, 9 Nov 2020 08:12:17 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D656F20663; Mon, 9 Nov 2020 13:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927536; bh=uBQpzeg9/W69UMZEoNOlR4jrZDydp8HudzXQWnZs5nU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0AFm7TBvA8BcoOrFjEXJ9+xa50nlRw2luG8ZDjBfC/MSDj7byBZa+X+D4e41g0XpI BQZbUL7p379Q4NFv4Tbvxhprc58VQb8MhAYCC0dQ8cg62LycWfLFPXloOlHq9kkyze YzI2m1vM8Ftp9HyS2pCCdZqrEL+JfOg2WQR6oR6o= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Andrew Lunn , Jakub Kicinski Subject: [PATCH 5.4 21/85] sfp: Fix error handing in sfp_probe() Date: Mon, 9 Nov 2020 13:55:18 +0100 Message-Id: <20201109125023.604471656@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125022.614792961@linuxfoundation.org> References: <20201109125022.614792961@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 9621618130bf7e83635367c13b9a6ee53935bb37 ] gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -1970,7 +1970,8 @@ static int sfp_probe(struct platform_dev continue; sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]); - if (!sfp->gpio_irq[i]) { + if (sfp->gpio_irq[i] < 0) { + sfp->gpio_irq[i] = 0; poll = true; continue; }