From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC15DC2D0A3 for ; Mon, 9 Nov 2020 13:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A2A32076E for ; Mon, 9 Nov 2020 13:24:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604928293; bh=khB+fXKKincLA3kRo0EB7b7vJ0Ib+IRQFqAu/sTvaOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=EaKlWjq595tlHVmFfqp4iHsG/NIfxLSmrr/eLe1+NeGnnfXyUlq0ugUbPX6LeYBXr rzxJbLt6ujESTiU6rO6sTe5pCejeJZuvPprbevPrkJGst+Br3MIH5l/M6FedwNeRfY ZSXVSQLp0eelyzqBGbQYz9zbU/9vyWBSvpXlYmis= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387906AbgKINYw (ORCPT ); Mon, 9 Nov 2020 08:24:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:46032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731863AbgKINSl (ORCPT ); Mon, 9 Nov 2020 08:18:41 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BDC042076E; Mon, 9 Nov 2020 13:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927920; bh=khB+fXKKincLA3kRo0EB7b7vJ0Ib+IRQFqAu/sTvaOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t2+nnS5QlPd5cV7uQPWC5ThWLYc2N/hYGGRgsYXHW5x7ivw15MyxA9eDHof+xN21l dmQ78OVc47WEd7kUNU10ayXeKSSoaCNCpc2ojxeUpggHV5UbaD5NwsoG9rUD8FzM4q CV0u90DIcBefSXYKmeRukA+tanHsk1F1CQNMtvWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, YueHaibing , Andrew Lunn , Jakub Kicinski Subject: [PATCH 5.9 036/133] sfp: Fix error handing in sfp_probe() Date: Mon, 9 Nov 2020 13:54:58 +0100 Message-Id: <20201109125032.446747892@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125030.706496283@linuxfoundation.org> References: <20201109125030.706496283@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing [ Upstream commit 9621618130bf7e83635367c13b9a6ee53935bb37 ] gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing Reviewed-by: Andrew Lunn Link: https://lore.kernel.org/r/20201031031053.25264-1-yuehaibing@huawei.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -2389,7 +2389,8 @@ static int sfp_probe(struct platform_dev continue; sfp->gpio_irq[i] = gpiod_to_irq(sfp->gpio[i]); - if (!sfp->gpio_irq[i]) { + if (sfp->gpio_irq[i] < 0) { + sfp->gpio_irq[i] = 0; sfp->need_poll = true; continue; }