From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver
Date: Mon, 9 Nov 2020 19:00:53 +0530 [thread overview]
Message-ID: <20201109133053.GK24289@work> (raw)
In-Reply-To: <1604684690-31065-1-git-send-email-bbhatt@codeaurora.org>
On Fri, Nov 06, 2020 at 09:44:44AM -0800, Bhaumik Bhatt wrote:
> This patch series serves to clean up the MHI host driver by removing an
> unnecessary counter and an unused function. It also renames a function to make
> it clearly worded. There is currently no user of this exported function which
> makes it is safe to do so now.
>
> Bug fixes include adding a missing EXPORT_SYMBOL_GPL to a function, and adding
> a return value check to bail out of RDDM download in kernel panic path.
>
> An outlier among the group exports the mhi_get_exec_env() API for use by
> controller drivers, in case they need to determine behavior on the basis of the
> current execution environment.
>
> This set of patches was tested on arm64.
Series applied to mhi-next!
Thanks,
Mani
>
> v2:
> -Removed the declaration for mhi_get_exec_env() from internal.h
> -Improved on the error log message in RDDM download exit case due to unknown EE
>
> Bhaumik Bhatt (6):
> bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
> bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state()
> bus: mhi: core: Expose mhi_get_exec_env() API for controllers
> bus: mhi: core: Remove unused mhi_fw_load_worker() declaration
> bus: mhi: core: Rename RDDM download function to use proper words
> bus: mhi: core: Skip RDDM download for unknown execution environment
>
> drivers/bus/mhi/core/boot.c | 15 +++++++++------
> drivers/bus/mhi/core/internal.h | 2 --
> drivers/bus/mhi/core/main.c | 2 ++
> include/linux/mhi.h | 12 +++++++++---
> 4 files changed, 20 insertions(+), 11 deletions(-)
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
prev parent reply other threads:[~2020-11-09 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 17:44 [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 1/6] bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy() Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 2/6] bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state() Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 3/6] bus: mhi: core: Expose mhi_get_exec_env() API for controllers Bhaumik Bhatt
2020-11-09 12:06 ` Manivannan Sadhasivam
2020-11-06 17:44 ` [PATCH v2 4/6] bus: mhi: core: Remove unused mhi_fw_load_worker() declaration Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 5/6] bus: mhi: core: Rename RDDM download function to use proper words Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 6/6] bus: mhi: core: Skip RDDM download for unknown execution environment Bhaumik Bhatt
2020-11-09 12:08 ` Manivannan Sadhasivam
2020-11-09 13:30 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109133053.GK24289@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox