From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDB8C2D0A3 for ; Mon, 9 Nov 2020 15:19:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F436206E3 for ; Mon, 9 Nov 2020 15:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731842AbgKIPTl (ORCPT ); Mon, 9 Nov 2020 10:19:41 -0500 Received: from mga14.intel.com ([192.55.52.115]:3905 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729289AbgKIPTk (ORCPT ); Mon, 9 Nov 2020 10:19:40 -0500 IronPort-SDR: b2HEHnXPbe+mHQ5JIAwFoSakoxfI5X2JnDfvKtI5UOWJYPCROx5cvzY6juptjNADDjplPVdoGa iKYMZY2wvWkw== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="169034074" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="169034074" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 07:19:40 -0800 IronPort-SDR: OCyFFHZMq2JFX08oDvfCI6sCxFj0j6Yf9l62oeSJVmxd/jzVADMD007L35+3roxB9OHfLhm5Ci i3YLdPYzDy8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="365507779" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 09 Nov 2020 07:19:37 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 09 Nov 2020 17:19:37 +0200 Date: Mon, 9 Nov 2020 17:19:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Lee Jones Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Message-ID: <20201109151937.GF6112@intel.com> References: <20201105144517.1826692-1-lee.jones@linaro.org> <20201105144517.1826692-15-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201105144517.1826692-15-lee.jones@linaro.org> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 05, 2020 at 02:45:12PM +0000, Lee Jones wrote: > The stack is too full. > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: > drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] > > Cc: David Airlie > Cc: Daniel Vetter > Cc: Lyude Paul > Cc: David Francis > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > .../drm/selftests/test-drm_dp_mst_helper.c | 29 ++++++++++++------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > index 1d696ec001cff..0a539456f6864 100644 > --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c > @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct drm_dp_sideband_msg_req_body *in, > static bool > sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) > { > - struct drm_dp_sideband_msg_req_body out = {0}; > + struct drm_dp_sideband_msg_req_body *out; How big is it? And why is it that big? -- Ville Syrjälä Intel