From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037B3C2D0A3 for ; Mon, 9 Nov 2020 17:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB167205CA for ; Mon, 9 Nov 2020 17:36:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732278AbgKIRga (ORCPT ); Mon, 9 Nov 2020 12:36:30 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43684 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732186AbgKIRg0 (ORCPT ); Mon, 9 Nov 2020 12:36:26 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kcB5a-0067LI-Jn; Mon, 09 Nov 2020 18:36:22 +0100 Date: Mon, 9 Nov 2020 18:36:22 +0100 From: Andrew Lunn To: Jisheng Zhang Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg Message-ID: <20201109173622.GC1456319@lunn.ch> References: <20201109091605.3951c969@xhacker.debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201109091605.3951c969@xhacker.debian> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote: > The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not > needed, because the phy core will call genphy_config_aneg() if the > .config_aneg is NULL. > > Signed-off-by: Jisheng Zhang Reviewed-by: Andrew Lunn Andrew