From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ira Weiny <ira.weiny@intel.com>, Jan Kara <jack@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: show the dax option in mount options.
Date: Mon, 9 Nov 2020 11:24:19 -0800 [thread overview]
Message-ID: <20201109192419.GC9695@magnolia> (raw)
In-Reply-To: <f9f7ba25e97dacd92c09eb3ee6a4aca8b4f72b00.1604948373.git.msuchanek@suse.de>
On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote:
> xfs accepts both dax and dax_enum but shows only dax_enum. Show both
> options.
>
> Fixes: 8d6c3446ec23 ("fs/xfs: Make DAX mount option a tri-state")
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index e3e229e52512..a3b00003840d 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -163,7 +163,7 @@ xfs_fs_show_options(
> { XFS_MOUNT_GRPID, ",grpid" },
> { XFS_MOUNT_DISCARD, ",discard" },
> { XFS_MOUNT_LARGEIO, ",largeio" },
> - { XFS_MOUNT_DAX_ALWAYS, ",dax=always" },
> + { XFS_MOUNT_DAX_ALWAYS, ",dax,dax=always" },
NAK, programs that require DAX semantics for files stored on XFS must
call statx to detect the STATX_ATTR_DAX flag, as outlined in "Enabling
DAX on xfs" in Documentation/filesystems/dax.txt.
--D
> { XFS_MOUNT_DAX_NEVER, ",dax=never" },
> { 0, NULL }
> };
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-11-09 19:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 19:10 [PATCH 0/2] Tristate moount option comatibility fixup Michal Suchanek
2020-11-09 19:10 ` [PATCH 1/2] xfs: show the dax option in mount options Michal Suchanek
2020-11-09 19:24 ` Eric Sandeen
2020-11-09 19:24 ` Darrick J. Wong [this message]
2020-11-09 20:27 ` Michal Suchánek
2020-11-09 21:08 ` Dave Chinner
2020-11-11 10:28 ` Michal Suchánek
2020-11-12 1:49 ` Dave Chinner
2020-11-12 11:12 ` Michal Suchánek
2020-11-12 15:10 ` Jan Kara
2020-11-12 16:08 ` Ira Weiny
2020-12-01 16:29 ` Michal Suchánek
2020-11-10 18:38 ` Christoph Hellwig
2020-11-09 19:10 ` [PATCH 2/2] ext4: " Michal Suchanek
2020-11-10 14:14 ` [PATCH 0/2] Tristate moount option comatibility fixup Theodore Y. Ts'o
2020-11-10 18:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109192419.GC9695@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox