Re: [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes into shared header

[Lee Jones <lee.jones@linaro.org>]

On Mon, 09 Nov 2020, Alex Deucher wrote:

> On Mon, Nov 9, 2020 at 4:19 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/gpu/drm/radeon/r600_hdmi.c:177:6: warning: no previous prototype for ‘r600_hdmi_update_acr’ [-Wmissing-prototypes]
> >  177 | void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset,
> >  | ^~~~~~~~~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:217:6: warning: no previous prototype for ‘r600_set_avi_packet’ [-Wmissing-prototypes]
> >  217 | void r600_set_avi_packet(struct radeon_device *rdev, u32 offset,
> >  | ^~~~~~~~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:314:6: warning: no previous prototype for ‘r600_hdmi_audio_set_dto’ [-Wmissing-prototypes]
> >  314 | void r600_hdmi_audio_set_dto(struct radeon_device *rdev,
> >  | ^~~~~~~~~~~~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:340:6: warning: no previous prototype for ‘r600_set_vbi_packet’ [-Wmissing-prototypes]
> >  340 | void r600_set_vbi_packet(struct drm_encoder *encoder, u32 offset)
> >  | ^~~~~~~~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:351:6: warning: no previous prototype for ‘r600_set_audio_packet’ [-Wmissing-prototypes]
> >  351 | void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset)
> >  | ^~~~~~~~~~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:393:6: warning: no previous prototype for ‘r600_set_mute’ [-Wmissing-prototypes]
> >  393 | void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute)
> >  | ^~~~~~~~~~~~~
> >  drivers/gpu/drm/radeon/r600_hdmi.c:469:6: warning: no previous prototype for ‘r600_hdmi_enable’ [-Wmissing-prototypes]
> >  469 | void r600_hdmi_enable(struct drm_encoder *encoder, bool enable)
> >  | ^~~~~~~~~~~~~~~~
> >
> > Cc: Alex Deucher <alexander.deucher@amd.com>
> > Cc: "Christian König" <christian.koenig@amd.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: amd-gfx@lists.freedesktop.org
> > Cc: dri-devel@lists.freedesktop.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/gpu/drm/radeon/r600d.h        | 14 ++++++++++++++
> >  drivers/gpu/drm/radeon/radeon_audio.c | 11 +----------
> >  2 files changed, 15 insertions(+), 10 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/r600d.h b/drivers/gpu/drm/radeon/r600d.h
> > index 2e00a5287bd2d..db4bcc8bee4e5 100644
> > --- a/drivers/gpu/drm/radeon/r600d.h
> > +++ b/drivers/gpu/drm/radeon/r600d.h
> > @@ -27,6 +27,20 @@
> >  #ifndef R600D_H
> >  #define R600D_H
> >
> > +struct radeon_crtc;
> > +struct radeon_hdmi_acr;
> > +
> > +void r600_set_audio_packet(struct drm_encoder *encoder, u32 offset);
> > +void r600_set_mute(struct drm_encoder *encoder, u32 offset, bool mute);
> > +void r600_hdmi_audio_set_dto(struct radeon_device *rdev,
> > +       struct radeon_crtc *crtc, unsigned int clock);
> > +void r600_set_avi_packet(struct radeon_device *rdev, u32 offset,
> > +       unsigned char *buffer, size_t size);
> > +void r600_hdmi_update_acr(struct drm_encoder *encoder, long offset,
> > +       const struct radeon_hdmi_acr *acr);
> > +void r600_set_vbi_packet(struct drm_encoder *encoder, u32 offset);
> > +void r600_hdmi_enable(struct drm_encoder *encoder, bool enable);
> > +
> 
> the *d.h headers are supposed to just be hardware definitions.  I'd
> prefer to keep driver stuff out of them.

That's fine (I did wonder if that were the case).

I need an answer from you and Sam whether I can create new headers.

For me, it is the right thing to do.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog