* [PATCH] ALSA: firewire: fix comparison to bool warning
@ 2020-11-07 16:13 xiakaixu1987
2020-11-10 8:06 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: xiakaixu1987 @ 2020-11-07 16:13 UTC (permalink / raw)
To: perex, tiwai; +Cc: alsa-devel, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
Fix the following coccicheck warning:
./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
sound/firewire/amdtp-stream.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
index 2ceb57d1d58e..a3daa1f2c1c4 100644
--- a/sound/firewire/amdtp-stream.h
+++ b/sound/firewire/amdtp-stream.h
@@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
unsigned int timeout)
{
return wait_event_timeout(s->callback_wait,
- s->callbacked == true,
+ s->callbacked,
msecs_to_jiffies(timeout)) > 0;
}
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: firewire: fix comparison to bool warning
2020-11-07 16:13 [PATCH] ALSA: firewire: fix comparison to bool warning xiakaixu1987
@ 2020-11-10 8:06 ` Takashi Iwai
2020-11-10 8:12 ` Takashi Sakamoto
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2020-11-10 8:06 UTC (permalink / raw)
To: xiakaixu1987; +Cc: perex, tiwai, alsa-devel, linux-kernel, Kaixu Xia
On Sat, 07 Nov 2020 17:13:31 +0100,
xiakaixu1987@gmail.com wrote:
>
> From: Kaixu Xia <kaixuxia@tencent.com>
>
> Fix the following coccicheck warning:
>
> ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
>
> Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Thanks, applied.
Takashi
> ---
> sound/firewire/amdtp-stream.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
> index 2ceb57d1d58e..a3daa1f2c1c4 100644
> --- a/sound/firewire/amdtp-stream.h
> +++ b/sound/firewire/amdtp-stream.h
> @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
> unsigned int timeout)
> {
> return wait_event_timeout(s->callback_wait,
> - s->callbacked == true,
> + s->callbacked,
> msecs_to_jiffies(timeout)) > 0;
> }
>
> --
> 2.20.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: firewire: fix comparison to bool warning
2020-11-10 8:06 ` Takashi Iwai
@ 2020-11-10 8:12 ` Takashi Sakamoto
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2020-11-10 8:12 UTC (permalink / raw)
To: Takashi Iwai; +Cc: xiakaixu1987, linux-kernel, alsa-devel, Kaixu Xia, tiwai
On Tue, Nov 10, 2020 at 09:06:29AM +0100, Takashi Iwai wrote:
> On Sat, 07 Nov 2020 17:13:31 +0100,
> xiakaixu1987@gmail.com wrote:
> >
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > Fix the following coccicheck warning:
> >
> > ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool
> >
> > Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
The message seems not to reach my mailbox. Anyway:
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Thanks, applied.
>
>
> Takashi
>
> > ---
> > sound/firewire/amdtp-stream.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/firewire/amdtp-stream.h b/sound/firewire/amdtp-stream.h
> > index 2ceb57d1d58e..a3daa1f2c1c4 100644
> > --- a/sound/firewire/amdtp-stream.h
> > +++ b/sound/firewire/amdtp-stream.h
> > @@ -270,7 +270,7 @@ static inline bool amdtp_stream_wait_callback(struct amdtp_stream *s,
> > unsigned int timeout)
> > {
> > return wait_event_timeout(s->callback_wait,
> > - s->callbacked == true,
> > + s->callbacked,
> > msecs_to_jiffies(timeout)) > 0;
> > }
> >
> > --
> > 2.20.0
Regards
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-10 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-07 16:13 [PATCH] ALSA: firewire: fix comparison to bool warning xiakaixu1987
2020-11-10 8:06 ` Takashi Iwai
2020-11-10 8:12 ` Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox