From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4032C55ABD for ; Tue, 10 Nov 2020 14:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87872206C0 for ; Tue, 10 Nov 2020 14:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731576AbgKJO0v (ORCPT ); Tue, 10 Nov 2020 09:26:51 -0500 Received: from mga17.intel.com ([192.55.52.151]:27997 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730059AbgKJO0v (ORCPT ); Tue, 10 Nov 2020 09:26:51 -0500 IronPort-SDR: 2UpuuUnYgUkZJm1lIdtDtQI6Nc9VMCgtPWEGL+taI65/AbhHnx5hg+EpDkToZ63U1KJHeQIBrn 9VV2ZpRlRWKg== X-IronPort-AV: E=McAfee;i="6000,8403,9800"; a="149828648" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="149828648" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 06:26:51 -0800 IronPort-SDR: lxYSFEGxy4Km5kAA/xUqloobFP4zJ/MpiwZQwkbSbDDKz//CYOgtcl5OCQVvtX6NgEGVR/nGzO b/oc46MGYCbQ== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="531224571" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 06:26:48 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kcUcg-005UvP-VG; Tue, 10 Nov 2020 16:27:50 +0200 Date: Tue, 10 Nov 2020 16:27:50 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jan Kiszka , David Laight , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap Message-ID: <20201110142750.GU4077@smile.fi.intel.com> References: <20201110123406.3261-1-brgl@bgdev.pl> <20201110123406.3261-7-brgl@bgdev.pl> <20201110142624.GT4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110142624.GT4077@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 04:26:24PM +0200, Andy Shevchenko wrote: > On Tue, Nov 10, 2020 at 01:34:05PM +0100, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > We can simplify the code in gpio-exar by using regmap. This allows us to > > drop the mutex (regmap provides its own locking) and we can also reuse > > regmap's bit operations instead of implementing our own update function. > > ... > > > + /* > > + * We don't need to check the return values of mmio regmap operations (unless > > + * the regmap has a clock attached which is not the case here). > > + */ > > + exar_gpio->regs = devm_regmap_init_mmio(dev, p, &exar_regmap_config); > > + if (IS_ERR(exar_gpio->regs)) > > + return PTR_ERR(exar_gpio->regs); > > > > index = ida_alloc(&ida_index, GFP_KERNEL); > > - if (index < 0) { > > - ret = index; > > - goto err_mutex_destroy; > > - } > > + if (index < 0) > > + return index; > > And below you effectively use p as regmap! > That's what renaming of variable regs -> regmap or map can easily reveal. > > exar_gpio->regs = p; Jan, if you remove this line, does it help? -- With Best Regards, Andy Shevchenko