Re: [PATCH v4 0/7] gpio: exar: refactor the driver

Andy Shevchenko
2020-11-10T15:07:04Z

On Tue, Nov 10, 2020 at 03:55:45PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> I just wanted to convert the driver to using simpler IDA API but ended up
> quickly converting it to using regmap. Unfortunately I don't have the HW
> to test it so marking the patches that introduce functional change as RFT
> and Cc'ing the original author.

Thanks.
With reverted reg_width change
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> v1 -> v2:
> - add new regmap helper: regmap_assign_bits()
> - fix lvl vs sel register access
> - set value in direction_output callback
>
> v2 -> v3:
> - drop the regmap helper from series
>
> v3 -> v4:
> - renamed the regmap variable to 'regmap' as leaving the old name caused me
> to miss an assignment leading to a crash (culprit spotted by Andy Shevchenko)
>
> Bartosz Golaszewski (7):
> gpio: exar: add a newline after the copyright notice
> gpio: exar: include idr.h
> gpio: exar: switch to a simpler IDA interface
> gpio: exar: use a helper variable for &pdev->dev
> gpio: exar: unduplicate address and offset computation
> gpio: exar: switch to using regmap
> gpio: exar: use devm action for freeing the IDA and drop remove()
>
> drivers/gpio/Kconfig | 1 +
> drivers/gpio/gpio-exar.c | 155 +++++++++++++++++++--------------------
> 2 files changed, 77 insertions(+), 79 deletions(-)
>
> --
> 2.29.1
>

--
With Best Regards,
Andy Shevchenko