From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3271C4742C for ; Tue, 10 Nov 2020 15:00:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D1B320797 for ; Tue, 10 Nov 2020 15:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731139AbgKJPAw (ORCPT ); Tue, 10 Nov 2020 10:00:52 -0500 Received: from mga02.intel.com ([134.134.136.20]:16060 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731054AbgKJPAv (ORCPT ); Tue, 10 Nov 2020 10:00:51 -0500 IronPort-SDR: KUJF6RES29JEwO8GNmj0G3+9RfsOV0WNV9XzypfBcjDD+C+xfqusOdCN4r2Pq1Yl57dkLfaRiU rRK4SL1RhWmg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="156990559" X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="156990559" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:00:43 -0800 IronPort-SDR: 0m+sLG7EaSBtlxIOGydFu1MSzxEGYua1iyjNhe/OIQVXozS4eZ8mzpYzjSPOymLLaXQJCkdVFl oPvRg773uhNA== X-IronPort-AV: E=Sophos;i="5.77,466,1596524400"; d="scan'208";a="327706939" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 07:00:41 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kcV9T-005VNY-0j; Tue, 10 Nov 2020 17:01:43 +0200 Date: Tue, 10 Nov 2020 17:01:43 +0200 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Jan Kiszka , Bartosz Golaszewski , Linus Walleij , David Laight , linux-gpio , LKML Subject: Re: [PATCH v3 6/7] gpio: exar: switch to using regmap Message-ID: <20201110150143.GV4077@smile.fi.intel.com> References: <20201110123406.3261-1-brgl@bgdev.pl> <20201110123406.3261-7-brgl@bgdev.pl> <20201110142624.GT4077@smile.fi.intel.com> <20201110142750.GU4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 03:52:00PM +0100, Bartosz Golaszewski wrote: > On Tue, Nov 10, 2020 at 3:50 PM Jan Kiszka wrote: > > On 10.11.20 15:30, Bartosz Golaszewski wrote: ... > > Removing the line that Andy found made things work here. And switching > > to 16 for reg_bits didn't make things worse again. > > > > Jan > > Alright! I'll send a v4 with these things fixed then. Hold on, the registers are 16-bit wide, but their halves are sparsed! So, I guess 8 and 8 with helpers to get hi and lo parts are essential. -- With Best Regards, Andy Shevchenko