* [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing
@ 2020-11-10 6:34 Leo Yan
2020-11-10 6:34 ` [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm Leo Yan
2020-11-10 18:05 ` [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Mathieu Poirier
0 siblings, 2 replies; 6+ messages in thread
From: Leo Yan @ 2020-11-10 6:34 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Suzuki Poulouse, Mathieu Poirier,
Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao,
linux-kernel, Coresight ML
Cc: Leo Yan
Fix a typo: s/devce_name/device_name.
Fixes: fe0aed19b266 ("perf test: Introduce script for Arm CoreSight testing")
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
Resend patches for adding "Fixes" tags.
tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh
index 8d84fdbed6a6..59d847d4981d 100755
--- a/tools/perf/tests/shell/test_arm_coresight.sh
+++ b/tools/perf/tests/shell/test_arm_coresight.sh
@@ -105,7 +105,7 @@ arm_cs_iterate_devices() {
# `> device_name = 'tmc_etf0'
device_name=$(basename $path)
- if is_device_sink $path $devce_name; then
+ if is_device_sink $path $device_name; then
record_touch_file $device_name $2 &&
perf_script_branch_samples touch &&
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm 2020-11-10 6:34 [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Leo Yan @ 2020-11-10 6:34 ` Leo Yan 2020-11-10 18:08 ` Mathieu Poirier 2020-11-10 18:05 ` [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Mathieu Poirier 1 sibling, 1 reply; 6+ messages in thread From: Leo Yan @ 2020-11-10 6:34 UTC (permalink / raw) To: Arnaldo Carvalho de Melo, Suzuki Poulouse, Mathieu Poirier, Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao, linux-kernel, Coresight ML Cc: Leo Yan Since the commit 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space counting"), 'exclude_guest=1' is set for user-space counting; and the branch sample's modifier has been altered, the sample event name has been changed from "branches:u:" to "branches:uH:", which gives out info for "user-space and host counting". But the cs-etm testing's regular expression cannot match the updated branch sample event and leads to test failure. This patch updates the branch sample parttern by using a more flexible expression '.*' to match branch sample's modifiers, so that allows the testing to work as expected. Fixes: 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space counting") Signed-off-by: Leo Yan <leo.yan@linaro.org> --- tools/perf/tests/shell/test_arm_coresight.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh index 59d847d4981d..18fde2f179cd 100755 --- a/tools/perf/tests/shell/test_arm_coresight.sh +++ b/tools/perf/tests/shell/test_arm_coresight.sh @@ -44,7 +44,7 @@ perf_script_branch_samples() { # touch 6512 1 branches:u: ffffb22082e0 strcmp+0xa0 (/lib/aarch64-linux-gnu/ld-2.27.so) # touch 6512 1 branches:u: ffffb2208320 strcmp+0xe0 (/lib/aarch64-linux-gnu/ld-2.27.so) perf script -F,-time -i ${perfdata} | \ - egrep " +$1 +[0-9]+ .* +branches:([u|k]:)? +" + egrep " +$1 +[0-9]+ .* +branches:(.*:)? +" } perf_report_branch_samples() { -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm 2020-11-10 6:34 ` [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm Leo Yan @ 2020-11-10 18:08 ` Mathieu Poirier 2020-11-10 18:19 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 6+ messages in thread From: Mathieu Poirier @ 2020-11-10 18:08 UTC (permalink / raw) To: Leo Yan Cc: Arnaldo Carvalho de Melo, Suzuki Poulouse, Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao, linux-kernel, Coresight ML On Tue, Nov 10, 2020 at 02:34:17PM +0800, Leo Yan wrote: > Since the commit 943b69ac1884 ("perf parse-events: Set exclude_guest=1 > for user-space counting"), 'exclude_guest=1' is set for user-space > counting; and the branch sample's modifier has been altered, the sample > event name has been changed from "branches:u:" to "branches:uH:", which > gives out info for "user-space and host counting". > > But the cs-etm testing's regular expression cannot match the updated > branch sample event and leads to test failure. > > This patch updates the branch sample parttern by using a more flexible s/parttern/pattern > expression '.*' to match branch sample's modifiers, so that allows the > testing to work as expected. > > Fixes: 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space counting") > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here too I would CC stable. With the above: Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh > index 59d847d4981d..18fde2f179cd 100755 > --- a/tools/perf/tests/shell/test_arm_coresight.sh > +++ b/tools/perf/tests/shell/test_arm_coresight.sh > @@ -44,7 +44,7 @@ perf_script_branch_samples() { > # touch 6512 1 branches:u: ffffb22082e0 strcmp+0xa0 (/lib/aarch64-linux-gnu/ld-2.27.so) > # touch 6512 1 branches:u: ffffb2208320 strcmp+0xe0 (/lib/aarch64-linux-gnu/ld-2.27.so) > perf script -F,-time -i ${perfdata} | \ > - egrep " +$1 +[0-9]+ .* +branches:([u|k]:)? +" > + egrep " +$1 +[0-9]+ .* +branches:(.*:)? +" > } > > perf_report_branch_samples() { > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm 2020-11-10 18:08 ` Mathieu Poirier @ 2020-11-10 18:19 ` Arnaldo Carvalho de Melo 2020-11-11 3:04 ` Leo Yan 0 siblings, 1 reply; 6+ messages in thread From: Arnaldo Carvalho de Melo @ 2020-11-10 18:19 UTC (permalink / raw) To: Mathieu Poirier Cc: Leo Yan, Suzuki Poulouse, Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao, linux-kernel, Coresight ML Em Tue, Nov 10, 2020 at 11:08:29AM -0700, Mathieu Poirier escreveu: > On Tue, Nov 10, 2020 at 02:34:17PM +0800, Leo Yan wrote: > > Since the commit 943b69ac1884 ("perf parse-events: Set exclude_guest=1 > > for user-space counting"), 'exclude_guest=1' is set for user-space > > counting; and the branch sample's modifier has been altered, the sample > > event name has been changed from "branches:u:" to "branches:uH:", which > > gives out info for "user-space and host counting". > > > > But the cs-etm testing's regular expression cannot match the updated > > branch sample event and leads to test failure. > > > > This patch updates the branch sample parttern by using a more flexible > > s/parttern/pattern I'll fix it and add stable@ to the CC list, thanks > > expression '.*' to match branch sample's modifiers, so that allows the > > testing to work as expected. > > > > Fixes: 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space counting") > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > --- > > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Here too I would CC stable. With the above: > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > > diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh > > index 59d847d4981d..18fde2f179cd 100755 > > --- a/tools/perf/tests/shell/test_arm_coresight.sh > > +++ b/tools/perf/tests/shell/test_arm_coresight.sh > > @@ -44,7 +44,7 @@ perf_script_branch_samples() { > > # touch 6512 1 branches:u: ffffb22082e0 strcmp+0xa0 (/lib/aarch64-linux-gnu/ld-2.27.so) > > # touch 6512 1 branches:u: ffffb2208320 strcmp+0xe0 (/lib/aarch64-linux-gnu/ld-2.27.so) > > perf script -F,-time -i ${perfdata} | \ > > - egrep " +$1 +[0-9]+ .* +branches:([u|k]:)? +" > > + egrep " +$1 +[0-9]+ .* +branches:(.*:)? +" > > } > > > > perf_report_branch_samples() { > > -- > > 2.17.1 > > -- - Arnaldo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm 2020-11-10 18:19 ` Arnaldo Carvalho de Melo @ 2020-11-11 3:04 ` Leo Yan 0 siblings, 0 replies; 6+ messages in thread From: Leo Yan @ 2020-11-11 3:04 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Mathieu Poirier, Suzuki Poulouse, Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao, linux-kernel, Coresight ML On Tue, Nov 10, 2020 at 03:19:29PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 10, 2020 at 11:08:29AM -0700, Mathieu Poirier escreveu: > > On Tue, Nov 10, 2020 at 02:34:17PM +0800, Leo Yan wrote: > > > Since the commit 943b69ac1884 ("perf parse-events: Set exclude_guest=1 > > > for user-space counting"), 'exclude_guest=1' is set for user-space > > > counting; and the branch sample's modifier has been altered, the sample > > > event name has been changed from "branches:u:" to "branches:uH:", which > > > gives out info for "user-space and host counting". > > > > > > But the cs-etm testing's regular expression cannot match the updated > > > branch sample event and leads to test failure. > > > > > > This patch updates the branch sample parttern by using a more flexible > > > > s/parttern/pattern > > I'll fix it and add stable@ to the CC list, thanks Thanks, Arnaldo and Mathieu. Will take care for sending stable list in next time. > > > expression '.*' to match branch sample's modifiers, so that allows the > > > testing to work as expected. > > > > > > Fixes: 943b69ac1884 ("perf parse-events: Set exclude_guest=1 for user-space counting") > > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > > > --- > > > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Here too I would CC stable. With the above: > > > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > > > > > diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh > > > index 59d847d4981d..18fde2f179cd 100755 > > > --- a/tools/perf/tests/shell/test_arm_coresight.sh > > > +++ b/tools/perf/tests/shell/test_arm_coresight.sh > > > @@ -44,7 +44,7 @@ perf_script_branch_samples() { > > > # touch 6512 1 branches:u: ffffb22082e0 strcmp+0xa0 (/lib/aarch64-linux-gnu/ld-2.27.so) > > > # touch 6512 1 branches:u: ffffb2208320 strcmp+0xe0 (/lib/aarch64-linux-gnu/ld-2.27.so) > > > perf script -F,-time -i ${perfdata} | \ > > > - egrep " +$1 +[0-9]+ .* +branches:([u|k]:)? +" > > > + egrep " +$1 +[0-9]+ .* +branches:(.*:)? +" > > > } > > > > > > perf_report_branch_samples() { > > > -- > > > 2.17.1 > > > > > -- > > - Arnaldo ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing 2020-11-10 6:34 [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Leo Yan 2020-11-10 6:34 ` [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm Leo Yan @ 2020-11-10 18:05 ` Mathieu Poirier 1 sibling, 0 replies; 6+ messages in thread From: Mathieu Poirier @ 2020-11-10 18:05 UTC (permalink / raw) To: Leo Yan Cc: Arnaldo Carvalho de Melo, Suzuki Poulouse, Mike Leach, Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim, Jin Yao, linux-kernel, Coresight ML On Tue, Nov 10, 2020 at 02:34:16PM +0800, Leo Yan wrote: > Fix a typo: s/devce_name/device_name. > > Fixes: fe0aed19b266 ("perf test: Introduce script for Arm CoreSight testing") > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > I would CC stable too. Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Resend patches for adding "Fixes" tags. > > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/tests/shell/test_arm_coresight.sh > index 8d84fdbed6a6..59d847d4981d 100755 > --- a/tools/perf/tests/shell/test_arm_coresight.sh > +++ b/tools/perf/tests/shell/test_arm_coresight.sh > @@ -105,7 +105,7 @@ arm_cs_iterate_devices() { > # `> device_name = 'tmc_etf0' > device_name=$(basename $path) > > - if is_device_sink $path $devce_name; then > + if is_device_sink $path $device_name; then > > record_touch_file $device_name $2 && > perf_script_branch_samples touch && > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-11 3:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-10 6:34 [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Leo Yan 2020-11-10 6:34 ` [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm Leo Yan 2020-11-10 18:08 ` Mathieu Poirier 2020-11-10 18:19 ` Arnaldo Carvalho de Melo 2020-11-11 3:04 ` Leo Yan 2020-11-10 18:05 ` [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing Mathieu Poirier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox