From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B352C56201 for ; Tue, 10 Nov 2020 21:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D51A206F1 for ; Tue, 10 Nov 2020 21:24:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qJB5Zpgh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732142AbgKJVX7 (ORCPT ); Tue, 10 Nov 2020 16:23:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731813AbgKJVX5 (ORCPT ); Tue, 10 Nov 2020 16:23:57 -0500 Received: from mail-ot1-x344.google.com (mail-ot1-x344.google.com [IPv6:2607:f8b0:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9327CC0613D6 for ; Tue, 10 Nov 2020 13:23:57 -0800 (PST) Received: by mail-ot1-x344.google.com with SMTP id z16so123185otq.6 for ; Tue, 10 Nov 2020 13:23:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dr4/3qS1+z62awA2yeRAPJfTGcaaGNWy1JcZr/XX9ak=; b=qJB5Zpgh2DcQJip8oRxmUAIY3KCoHWN+gGyc1cjRJrqFsrRT7IZEUXIS2eTD1qiqDm V4l6KPbE5UizU6/e1NKrT568+zDu1rUaeRBumZ9RvaQIcoea4qZ3Tz5U492nFn+Ox5l2 yVyjinHo4CG79Xi8r3Hi0PzCWQqlYV/3DamEfz1wcA80kc16BdTnBWDoMczqW5ylNG1C G0TiI9VPDRPDTHpGlXgZz6tfawo/us1B9eWEXyTUrSZI8gCnROFg+xoQQym84nqx/oeq Q8/G/AsgIItcP/UY7J6chaaAOMxQaaTTfbqRbahXHYt11Uxs9KO/9/ilwSUdZjrywhRi DvGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dr4/3qS1+z62awA2yeRAPJfTGcaaGNWy1JcZr/XX9ak=; b=aI5iCc/DskSfHJr/SpGZTR9+1YHcrvC58KXJH9nZCG3P+c+nXgAv42Vgw/LEu9Ogg+ as7ZCOmhwf1XsXs5/lXPfvCsOnVQ7NsF0m0CYS3ZQ80N8gam40eJ4JjE8OCLWYhp4Ylt Smi8EUKbLHkEZd4wnx876G2v2Jh2RHogX1SCN0YZkzdbX2yv4rBgfSIcTuGXNHGglpJk kAkfQDKi7LkskvEveEOkbQcsb1iwdjkjQOnTLPZPnURRaaWw8OfOQmDFUgGTqz/sCJjf spvCNfm23LzS3PjZ41CE0zoIHIes1FPNspH0M9XQ2D+WeW3ycqD8XdsYYws8kVPqvG8y /h6g== X-Gm-Message-State: AOAM530e+ap7cYo9YhlKxaw+friN9S36iQizEhkcWcc7ayHRwqaPOQP3 d7gNOoP56QvVn0bWMRjGpCi4TQ== X-Google-Smtp-Source: ABdhPJzJKZ16lT+yRBdEqTcDBQJwsR0BhG8D1cx/opTemZEoXfw4V6Tf/LBN/7cbuzaHSu45NrnbnQ== X-Received: by 2002:a9d:192d:: with SMTP id j45mr14979829ota.207.1605043436560; Tue, 10 Nov 2020 13:23:56 -0800 (PST) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id s4sm34800oov.46.2020.11.10.13.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Nov 2020 13:23:55 -0800 (PST) Date: Tue, 10 Nov 2020 15:23:53 -0600 From: Bjorn Andersson To: Rajendra Nayak Cc: agross@kernel.org, linus.walleij@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] pinctrl: qcom: Add sc7280 pinctrl driver Message-ID: <20201110212353.GD807@yoga> References: <1604570192-15057-1-git-send-email-rnayak@codeaurora.org> <1604570192-15057-2-git-send-email-rnayak@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604570192-15057-2-git-send-email-rnayak@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 05 Nov 03:56 CST 2020, Rajendra Nayak wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c [..] > +static const struct msm_pinctrl_soc_data sc7280_pinctrl = { > + .pins = sc7280_pins, > + .npins = ARRAY_SIZE(sc7280_pins), > + .functions = sc7280_functions, > + .nfunctions = ARRAY_SIZE(sc7280_functions), > + .groups = sc7280_groups, > + .ngroups = ARRAY_SIZE(sc7280_groups), > + .ngpios = 176, I presume the wakeirq_map will come later. Nothing to hold up this patch for, but please help me remember to not merge the tlmm node with a wakeup-parent specified before that. Reviewed-by: Bjorn Andersson Regards, Bjorn