From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF58EC388F7 for ; Wed, 11 Nov 2020 01:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9628922202 for ; Wed, 11 Nov 2020 01:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732483AbgKKBJV (ORCPT ); Tue, 10 Nov 2020 20:09:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732421AbgKKBJU (ORCPT ); Tue, 10 Nov 2020 20:09:20 -0500 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0C8CC0613D1 for ; Tue, 10 Nov 2020 17:09:20 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcedK-003BHU-BW; Wed, 11 Nov 2020 01:09:10 +0000 Date: Wed, 11 Nov 2020 01:09:10 +0000 From: Al Viro To: Ansuel Smith Cc: Will Deacon , Catalin Marinas , Andrew Morton , Mark Rutland , Pavel Tatashin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: fix missing include in asm uaccess.h Message-ID: <20201111010910.GZ3576660@ZenIV.linux.org.uk> References: <20201111004440.8783-1-ansuelsmth@gmail.com> <20201111005826.GY3576660@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111005826.GY3576660@ZenIV.linux.org.uk> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 12:58:26AM +0000, Al Viro wrote: > On Wed, Nov 11, 2020 at 01:44:38AM +0100, Ansuel Smith wrote: > > Fix a compilation error as PF_KTHREAD is defined in linux/sched.h and > > this is missing. > > > > Fixes: df325e05a682 ("arm64: Validate tagged addresses in access_ok() > > called from kernel threads") > > Signed-off-by: Ansuel Smith > > --- > > arch/arm64/include/asm/uaccess.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h > > index 991dd5f031e4..51a4f63f464a 100644 > > --- a/arch/arm64/include/asm/uaccess.h > > +++ b/arch/arm64/include/asm/uaccess.h > > @@ -7,6 +7,8 @@ > > #ifndef __ASM_UACCESS_H > > #define __ASM_UACCESS_H > > > > +#include > > + > > #include > > #include > > #include > > NAK. The real bug is in arch/arm64/include/asm/asm-prototypes.h - > it has no business pulling asm/uaccess.h > > Just include linux/uaccess.h instead. BTW, $ grep -n uaccess.h `find -name asm-prototypes.h` ./arch/alpha/include/asm/asm-prototypes.h:7:#include ./arch/arm64/include/asm/asm-prototypes.h:18:#include ./arch/ia64/include/asm/asm-prototypes.h:12:#include ./arch/mips/include/asm/asm-prototypes.h:6:#include ./arch/powerpc/include/asm/asm-prototypes.h:14:#include ./arch/sparc/include/asm/asm-prototypes.h:9:#include ./arch/x86/include/asm/asm-prototypes.h:3:#include Spot the irregularity... While we are at it, $ git grep -n -w '#.*include.*asm/uaccess.h' arch/arm64/include/asm/asm-prototypes.h:18:#include arch/nds32/math-emu/fpuemu.c:5:#include arch/powerpc/kvm/book3s_xive_native.c:15:#include arch/powerpc/mm/book3s64/radix_pgtable.c:30:#include drivers/s390/net/ctcm_mpc.c:50:#include /* instead of ok ? */ include/linux/uaccess.h:11:#include The last one is the only such include that should exist; drivers/s390 one is obviously a false positive. And IMO the right thing to do is to replace the remaining arch/* instances with includes of linux/uaccess.h. All of those are asking for trouble; any change moving e.g. a common variant of some primitive into linux/uaccess.h might end up breaking those.