Re: [PATCH v8 09/26] memory: tegra30: Support interconnect framework

Dmitry Osipenko
2020-11-11T06:14:48Z

11.11.2020 08:53, Viresh Kumar пишет:
>> +static int tegra_emc_opp_table_init(struct tegra_emc *emc)
>> +{
>> + struct opp_table *reg_opp_table = NULL, *clk_opp_table, *hw_opp_table;
>> + u32 hw_version = BIT(tegra_sku_info.soc_speedo_id);
>> + const char *rname = "core";
>> + int err;
>> +
>> + /*
>> + * Legacy device-trees don't have OPP table and EMC driver isn't
>> + * useful in this case.
>> + */
>> + if (!device_property_present(emc->dev, "operating-points-v2")) {
> I don't understand why you want to check this ? The below call to
> dev_pm_opp_of_add_table() will fail anyway and that should be good for
> you.
>

The dev_pm_opp_of_add_table() will produce a error message which doesn't
give a clue about what's wrong, i.e. that device-tree needs to be updated.