From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CB1C388F9 for ; Wed, 11 Nov 2020 09:37:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1054C20756 for ; Wed, 11 Nov 2020 09:37:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Cvx5O29Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726593AbgKKJhr (ORCPT ); Wed, 11 Nov 2020 04:37:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:33072 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgKKJhp (ORCPT ); Wed, 11 Nov 2020 04:37:45 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E49DB206D9; Wed, 11 Nov 2020 09:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605087464; bh=u4oI8akQtycIQ1Xqcemww5azjG8IkNdslx5h41epaP4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Cvx5O29QZC+AuIXemq0yVCbtzrtqtssfYXKiRvBToLCz/6WPI0ELTefhiwmV3Eozb K/YjT+7Hz50ouvJ53rpdoJT3vTtRIFaZC8zUHJUa9u4T8whmJ0HVlPt7sJIu0xz7Qs ZX47XTuBc1nBnx8KsX8Cvqw2k/qZ4UIs2S2tb2j8= Date: Wed, 11 Nov 2020 18:37:42 +0900 From: Masami Hiramatsu To: Chen Yu Cc: Linux Kernel Mailing List Subject: Re: bootconfig length parse error in kernel Message-Id: <20201111183742.e7c90597216343d9d2ffcb4e@kernel.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chen, On Tue, 10 Nov 2020 23:39:53 +0800 Chen Yu wrote: > Hi Masami, > Thanks for writing bootconfig and it is useful for boot up trace event > debugging. Thanks for testing! > However it was found that on 5.10-rc2 the bootconfig does not work and it shows > "'bootconfig' found on command line, but no bootconfig found" > And the reason for this is the kernel found the magic number to be incorrect. > I've added some hack in kernel to dump the first 12 bytes, it shows: > "OTCONFIG". So printed more content ahead we can find > "#BOOTCONFIG" ahead. So it looks that there is some alignment during > initrd load, and get_boot_config_from_initrd() might also deal with it. That is > to say: > data = (char *)initrd_end - BOOTCONFIG_MAGIC_LEN; > might do some alignment? Hrm, interesting. So initrd_end might be aligned. Could you print out the actuall address of initrd_end? And could you tell me which platform are you tested? Thank you, -- Masami Hiramatsu