From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1353C2D0A3 for ; Thu, 12 Nov 2020 08:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C19C20709 for ; Thu, 12 Nov 2020 08:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726291AbgKLIIH (ORCPT ); Thu, 12 Nov 2020 03:08:07 -0500 Received: from mslow2.mail.gandi.net ([217.70.178.242]:35450 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbgKLIIG (ORCPT ); Thu, 12 Nov 2020 03:08:06 -0500 Received: from relay12.mail.gandi.net (unknown [217.70.178.232]) by mslow2.mail.gandi.net (Postfix) with ESMTP id 602863B747B for ; Thu, 12 Nov 2020 08:02:27 +0000 (UTC) Received: from windsurf (lfbn-tou-1-236-25.w86-201.abo.wanadoo.fr [86.201.80.25]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 25618200004; Thu, 12 Nov 2020 08:02:03 +0000 (UTC) Date: Thu, 12 Nov 2020 09:02:02 +0100 From: Thomas Petazzoni To: Chris Packham Cc: akpm@linux-foundation.org, rppt@kernel.org, thomas.petazzoni@free-electrons.com, arnd@arndb.de, jason@lakedaemon.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap() Message-ID: <20201112090202.638c0c13@windsurf> In-Reply-To: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz> References: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020 16:21:49 +1300 Chris Packham wrote: > make coccicheck complains: > > ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111 > > It took some staring but I don't think there is a problem because the > file global `mbus_state` is passed mvebu_mbus_common_init() as the > `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base` > are the same thing. But this is confusing for anyone reading the code > and one less complaint from coccicheck would be nice so lets fix it. > > Signed-off-by: Chris Packham Acked-by: Thomas Petazzoni Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com