Re: [PATCH v1] spi: fix client driver breakages when using GPIO descriptors

Sven Van Asbroeck
2020-11-11T16:24:28Z

On Wed, Nov 11, 2020 at 10:48 AM Mark Brown <broonie@kernel.org> wrote:
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thank you !

Now that our minds are still focused on this subject, should
commit 138c9c32f090 ("spi: spidev: Fix CS polarity if GPIO descriptors
are used")
be reverted?

This fixed spidev to deal with SPI_CS_HIGH on gpiod.
But after our fix, its behaviour will probably be broken again.

Another candidate for revert is
commit ada9e3fcc175 ("spi: dw: Correct handling of native chipselect")
although I don't understand that code well enough to be sure.

Adding Charles Keepax.