linux-next: Fixes tag needs some work in the vfs-fixes tree

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hi all,

In commit

  de80166a573d ("aio: Fix io_pgetevents() struct __compat_aio_sigset layout")

Fixes tag

  Fixes: 7a074e96 ("aio: implement io_pgetevents")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi all,

In commit

  bcf0d9d4b769 ("ecryptfs: fix unlink and rmdir in face of underlying fs modifications")

Fixes tag

  Fixes: 74dd7c97ea2 "ecryptfs_rename(): verify that lower dentries are still OK after lock_rename()"

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

In commit

  5f85b351d3d6 ("fix return values of seq_read_iter()")

Fixes tag

  Fixes: d4d50710a8b (seq_file: add seq_read_iter)

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

Also, just use

  git log -1 --format='Fixes: %h ("%s")' <commit>

to generate Fixes tags.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vfs-fixes tree

[Al Viro]

On Fri, Nov 13, 2020 at 08:02:39AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   5f85b351d3d6 ("fix return values of seq_read_iter()")
> 
> Fixes tag
> 
>   Fixes: d4d50710a8b (seq_file: add seq_read_iter)
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long

Dealt with and force-pushed...

>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").
> 
> Also, just use
> 
>   git log -1 --format='Fixes: %h ("%s")' <commit>
> 
> to generate Fixes tags.

OK, will keep that in mind next time...

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi all,

In commit

  595a48eb7b48 ("hostfs: fix memory handling in follow_link()")

Fixes tag

  Fixes: 52b209f7b848 "get rid of hostfs_read_inode()" # v2.6.35+

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

The version comment is unneeded as it can be trivially gained from
"git describe".

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi all,

In commit

  bba1f6758a9e ("lirc: rc_dev_get_from_fd(): fix file leak")

Fixes tag

  Fixes: 6a9d552483d50 "media: rc: bpf attach/detach requires write permission" # v6.9

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Thus:

Fixes: 6a9d552483d5 ("media: rc: bpf attach/detach requires write permission")

In commit

  b4cf5fc01ce8 ("powerpc: fix a file leak in kvm_vcpu_ioctl_enable_cap()")

Fixes tag

  Fixes: eacc56bb9de3e # v5.2

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

Thus:

Fixes: eacc56bb9de3 ("KVM: PPC: Book3S HV: XIVE: Introduce a new capability KVM_CAP_PPC_IRQ_XIVE")



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Hi all,

In commit

  93ddd3942493 ("do_move_mount(): don't leak MNTNS_PROPAGATING on failures")

Fixes tag

  Fixes: 064fe6e233e8 "mount: handle mount propagation for detached mount trees" v6.15+

has these problem(s):

  - Subject has leading but no trailing quotes
  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 064fe6e233e8 ("mount: handle mount propagation for detached mount trees")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  72dbec48ca3c ("do_umount(): add missing barrier before refcount checks in sync case")

Fixes tag

  Fixes: 48a066e72d97 ("RCU'd vsfmounts")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

So:

Fixes: 48a066e72d97 ("RCU'd vfsmounts")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the vfs-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

Hi all,

On Tue, 29 Apr 2025 19:15:20 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> In commit
> 
>   72dbec48ca3c ("do_umount(): add missing barrier before refcount checks in sync case")

This is now commit

  b2478f9bd75a ("do_umount(): add missing barrier before refcount checks in sync case")

> Fixes tag
> 
>   Fixes: 48a066e72d97 ("RCU'd vsfmounts")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
>         git log -1 --format='Fixes: %h ("%s")'
> 
> So:
> 
> Fixes: 48a066e72d97 ("RCU'd vfsmounts")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]