public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] reboot: sync documentation with current code
@ 2020-11-13  1:07 Matteo Croce
  2020-11-13  1:50 ` Matteo Croce
  0 siblings, 1 reply; 2+ messages in thread
From: Matteo Croce @ 2020-11-13  1:07 UTC (permalink / raw)
  To: linux-kernel, akpm; +Cc: Nathan Chancellor, pmladek, ndesaulniers

From: Matteo Croce <mcroce@microsoft.com>

The valid values accepted by /sys/kernel/reboot/type are a bit different
that the ones used in the kernel command line.

In /sys we supports 'cf9_force' and 'cf9_safe', while in the kernel command
line 'pci' and 'q' are used.

Document the right values in the sysfs documentation.

Fixes: eab8da48579d ("reboot: allow to specify reboot mode via sysfs")
Signed-off-by: Matteo Croce <mcroce@microsoft.com>
---
 Documentation/ABI/testing/sysfs-kernel-reboot | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-kernel-reboot b/Documentation/ABI/testing/sysfs-kernel-reboot
index 837330fb2511..fcc5d193c16c 100644
--- a/Documentation/ABI/testing/sysfs-kernel-reboot
+++ b/Documentation/ABI/testing/sysfs-kernel-reboot
@@ -16,7 +16,8 @@ What:		/sys/kernel/reboot/type
 Date:		November 2020
 KernelVersion:	5.11
 Contact:	Matteo Croce <mcroce@microsoft.com>
-Description:	Reboot type. Valid values are: bios acpi kbd triple efi pci
+Description:	Reboot type. Valid values are:
+		bios acpi kbd triple efi cf9_force cf9_safe
 
 What:		/sys/kernel/reboot/cpu
 Date:		November 2020
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] reboot: sync documentation with current code
  2020-11-13  1:07 [PATCH] reboot: sync documentation with current code Matteo Croce
@ 2020-11-13  1:50 ` Matteo Croce
  0 siblings, 0 replies; 2+ messages in thread
From: Matteo Croce @ 2020-11-13  1:50 UTC (permalink / raw)
  To: linux-kernel, Andrew Morton
  Cc: Nathan Chancellor, Petr Mladek, Nick Desaulniers

On Fri, Nov 13, 2020 at 2:07 AM Matteo Croce <mcroce@linux.microsoft.com> wrote:
>
> From: Matteo Croce <mcroce@microsoft.com>
>
> The valid values accepted by /sys/kernel/reboot/type are a bit different
> that the ones used in the kernel command line.
>
> In /sys we supports 'cf9_force' and 'cf9_safe', while in the kernel command
> line 'pci' and 'q' are used.
>
> Document the right values in the sysfs documentation.
>
> Fixes: eab8da48579d ("reboot: allow to specify reboot mode via sysfs")
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
>  Documentation/ABI/testing/sysfs-kernel-reboot | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-kernel-reboot b/Documentation/ABI/testing/sysfs-kernel-reboot
> index 837330fb2511..fcc5d193c16c 100644
> --- a/Documentation/ABI/testing/sysfs-kernel-reboot
> +++ b/Documentation/ABI/testing/sysfs-kernel-reboot
> @@ -16,7 +16,8 @@ What:         /sys/kernel/reboot/type
>  Date:          November 2020
>  KernelVersion: 5.11
>  Contact:       Matteo Croce <mcroce@microsoft.com>
> -Description:   Reboot type. Valid values are: bios acpi kbd triple efi pci
> +Description:   Reboot type. Valid values are:
> +               bios acpi kbd triple efi cf9_force cf9_safe
>
>  What:          /sys/kernel/reboot/cpu
>  Date:          November 2020
> --
> 2.28.0
>

So, discard this one, I will rename 'cf9_force' to 'pci' instead.
Simpler, and coherent with the kernel cmdline.

-- 
per aspera ad upstream

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-13  1:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-13  1:07 [PATCH] reboot: sync documentation with current code Matteo Croce
2020-11-13  1:50 ` Matteo Croce

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox