From: Chen Yu <yu.c.chen@intel.com>
To: "Raj, Ashok" <ashok.raj@intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@intel.com>,
Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode
Date: Fri, 13 Nov 2020 09:33:06 +0800 [thread overview]
Message-ID: <20201113013306.GA13261@chenyu-office.sh.intel.com> (raw)
In-Reply-To: <20201112215442.GA40035@otc-nc-03>
Hi Ashok,
On Thu, Nov 12, 2020 at 01:54:42PM -0800, Raj, Ashok wrote:
> Hi ChenYu
>
> I think you can drop the RFC tag.
>
> I suppose you can add Cc stable as well. Boris should return next week to
> take a look.
>
Ok, I'll do and send another version out.
>
> On Tue, Nov 10, 2020 at 09:52:47PM +0800, Chen Yu wrote:
> > Currently scan_microcode() leverages microcode_matches() to check if the
> > microcode matches the CPU by comparing the family and model. However before
> > saving the microcode in scan_microcode(), the processor stepping and flag
> > of the microcode signature should also be considered in order to avoid
> > incompatible update and caused the failure of microcode update.
> >
> >
> > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208535
> > Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
> > Suggested-by: "Raj, Ashok" <ashok.raj@intel.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: "Raj, Ashok" <ashok.raj@intel.com>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> > --
>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
>
Thanks!
Best,
Chenyu
> Cheers,
> Ashok
prev parent reply other threads:[~2020-11-13 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 13:52 [PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode Chen Yu
2020-11-12 21:54 ` Raj, Ashok
2020-11-13 1:33 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113013306.GA13261@chenyu-office.sh.intel.com \
--to=yu.c.chen@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox