From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64389C2D0E4 for ; Fri, 13 Nov 2020 01:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DBD2216C4 for ; Fri, 13 Nov 2020 01:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbgKMBaj (ORCPT ); Thu, 12 Nov 2020 20:30:39 -0500 Received: from mga14.intel.com ([192.55.52.115]:51884 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725965AbgKMBaj (ORCPT ); Thu, 12 Nov 2020 20:30:39 -0500 IronPort-SDR: ihf3dvVSbI1AI7Ue4Z4I4ArCKH3PAOso3lEXbapnapGc5wDKuyi79YXMEld4x8Llqau2dN+Mdr XuDdGv8vtvCA== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="169627198" X-IronPort-AV: E=Sophos;i="5.77,473,1596524400"; d="scan'208";a="169627198" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 17:30:38 -0800 IronPort-SDR: AJf5rkZSeMBbMQfn3OsMTor6bEcGswjIml/HoDjxLgcBK5LSEwGq3SNYN8saGLJNI4Rz5TSTzG YLHa7WKr7SiA== X-IronPort-AV: E=Sophos;i="5.77,473,1596524400"; d="scan'208";a="542477697" Received: from chenyu-office.sh.intel.com ([10.239.158.173]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 17:30:35 -0800 Date: Fri, 13 Nov 2020 09:33:06 +0800 From: Chen Yu To: "Raj, Ashok" Cc: Borislav Petkov , Len Brown , "Rafael J. Wysocki" , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski Subject: Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and processor flag before saving microcode Message-ID: <20201113013306.GA13261@chenyu-office.sh.intel.com> References: <20201110135247.422-1-yu.c.chen@intel.com> <20201112215442.GA40035@otc-nc-03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112215442.GA40035@otc-nc-03> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ashok, On Thu, Nov 12, 2020 at 01:54:42PM -0800, Raj, Ashok wrote: > Hi ChenYu > > I think you can drop the RFC tag. > > I suppose you can add Cc stable as well. Boris should return next week to > take a look. > Ok, I'll do and send another version out. > > On Tue, Nov 10, 2020 at 09:52:47PM +0800, Chen Yu wrote: > > Currently scan_microcode() leverages microcode_matches() to check if the > > microcode matches the CPU by comparing the family and model. However before > > saving the microcode in scan_microcode(), the processor stepping and flag > > of the microcode signature should also be considered in order to avoid > > incompatible update and caused the failure of microcode update. > > > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208535 > > Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading") > > Suggested-by: "Raj, Ashok" > > Cc: Borislav Petkov > > Cc: Len Brown > > Cc: "Rafael J. Wysocki" > > Cc: "Raj, Ashok" > > Cc: Tony Luck > > Signed-off-by: Chen Yu > > -- > > Reviewed-by: Ashok Raj > Thanks! Best, Chenyu > Cheers, > Ashok