From: Kees Cook <keescook@chromium.org>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH] perf/x86: fix sysfs type mismatches
Date: Fri, 13 Nov 2020 10:59:01 -0800 [thread overview]
Message-ID: <202011131058.C331BE3C@keescook> (raw)
In-Reply-To: <20201113183126.1239404-1-samitolvanen@google.com>
On Fri, Nov 13, 2020 at 10:31:26AM -0800, Sami Tolvanen wrote:
> This change switches rapl to use PMU_FORMAT_ATTR, and fixes two other
> macros to use device_attribute instead of kobj_attribute to avoid
> callback type mismatches that trip indirect call checking with Clang's
> Control-Flow Integrity (CFI).
>
> Reported-by: Sedat Dilek <sedat.dilek@gmail.com>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-11-13 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 18:31 [PATCH] perf/x86: fix sysfs type mismatches Sami Tolvanen
2020-11-13 18:59 ` Kees Cook [this message]
2020-11-17 10:19 ` Peter Zijlstra
2020-11-19 9:55 ` [tip: perf/urgent] " tip-bot2 for Sami Tolvanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011131058.C331BE3C@keescook \
--to=keescook@chromium.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox