From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98927C388F7 for ; Fri, 13 Nov 2020 14:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6577722226 for ; Fri, 13 Nov 2020 14:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726731AbgKMONF (ORCPT ); Fri, 13 Nov 2020 09:13:05 -0500 Received: from foss.arm.com ([217.140.110.172]:38898 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbgKMONE (ORCPT ); Fri, 13 Nov 2020 09:13:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 690EE142F; Fri, 13 Nov 2020 06:13:04 -0800 (PST) Received: from bogus (unknown [10.57.15.107]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BEBDF3F6CF; Fri, 13 Nov 2020 06:13:02 -0800 (PST) Date: Fri, 13 Nov 2020 14:12:59 +0000 From: Sudeep Holla To: Ionela Voinescu Cc: catalin.marinas@arm.com, mark.rutland@arm.com, will@kernel.org, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] arm64: split counter validation function Message-ID: <20201113141259.hrvpir2oit3ncm7t@bogus> References: <20201106125334.21570-1-ionela.voinescu@arm.com> <20201106125334.21570-3-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106125334.21570-3-ionela.voinescu@arm.com> User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 06, 2020 at 12:53:33PM +0000, Ionela Voinescu wrote: > In order for the counter validation function to be reused, split > validate_cpu_freq_invariance_counters() into: > - freq_counters_valid(cpu) - check cpu for valid cycle counters > - freq_inv_set_max_ratio(int cpu, u64 max_rate, u64 ref_rate) - > generic function that sets the normalization ratio used by > topology_scale_freq_tick() > Reviewed-by: Sudeep Holla -- Regards, Sudeep