From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 25FF3C388F7
	for <linux-kernel@archiver.kernel.org>; Fri, 13 Nov 2020 17:30:24 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C561421D1A
	for <linux-kernel@archiver.kernel.org>; Fri, 13 Nov 2020 17:30:23 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726162AbgKMRaW (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Fri, 13 Nov 2020 12:30:22 -0500
Received: from foss.arm.com ([217.140.110.172]:42582 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725966AbgKMRaW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Nov 2020 12:30:22 -0500
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
        by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 970751042;
        Fri, 13 Nov 2020 09:30:21 -0800 (PST)
Received: from C02TD0UTHF1T.local (unknown [10.57.53.36])
        by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 07F403F718;
        Fri, 13 Nov 2020 09:30:14 -0800 (PST)
Date:   Fri, 13 Nov 2020 17:30:12 +0000
From:   Mark Rutland <mark.rutland@arm.com>
To:     Ionela Voinescu <ionela.voinescu@arm.com>
Cc:     catalin.marinas@arm.com, sudeep.holla@arm.com, will@kernel.org,
        morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: abort counter_read_on_cpu() when irqs_disabled()
Message-ID: <20201113173012.GD44988@C02TD0UTHF1T.local>
References: <20201106125334.21570-1-ionela.voinescu@arm.com>
 <20201113155328.4194-1-ionela.voinescu@arm.com>
 <20201113160234.GB44988@C02TD0UTHF1T.local>
 <20201113165843.GA6973@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201113165843.GA6973@arm.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 13, 2020 at 04:58:43PM +0000, Ionela Voinescu wrote:
> On Friday 13 Nov 2020 at 16:02:34 (+0000), Mark Rutland wrote:
> > On Fri, Nov 13, 2020 at 03:53:28PM +0000, Ionela Voinescu wrote:
> > > Given that smp_call_function_single() can deadlock when interrupts are
> > > disabled, abort the SMP call if irqs_disabled(). This scenario is
> > > currently not possible given the function's uses, but safeguard this for
> > > potential future uses.
> > 
> > Sorry to contradict earlier feedback, but I think this is preferable
> > as-is, since smp_call_function_single() will
> > WARN_ON_ONCE(irqs_disabled())), but this will silently mask any dodgy
> > usage.
> 
> Probably it only contradicts the chosen implementation.
> 
> > 
> > If we want a separate check here, I reckon we should wrap it with a
> > WARN_ON_ONCE(), and only relax that if/when we have a legitimate case
> > for calling this with IRQs disabled.
> > 
> 
> That's fair. I'll replace the condition below with:
> 
> 	if (!cpu_has_amu_feat(cpu))
> 		return -EOPNOTSUPP;
> 
> 	if (WARN_ON_ONCE(irqs_disabled())
> 		return -EPERM;

That'd be great, thanks!

With that, feel free to add:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.