Re: [PATCH v2 1/2] x86/pci: use unsigned int in check_reserved_t

Randy Dunlap
2020-11-14T01:20:13Z

On 11/13/20 4:23 PM, Sami Tolvanen wrote:
> Use unsigned int instead of raw unsigned in check_reserved_t to follow
> the kernel's style guidelines.
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> arch/x86/pci/mmconfig-shared.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> index 6fa42e9c4e6f..37f31dd7005a 100644
> --- a/arch/x86/pci/mmconfig-shared.c
> +++ b/arch/x86/pci/mmconfig-shared.c
> @@ -425,7 +425,7 @@ static acpi_status find_mboard_resource(acpi_handle handle, u32 lvl,
> return AE_OK;
> }
>
> -static bool is_acpi_reserved(u64 start, u64 end, unsigned not_used)
> +static bool is_acpi_reserved(u64 start, u64 end, unsigned int not_used)
> {
> struct resource mcfg_res;
>
> @@ -442,7 +442,7 @@ static bool is_acpi_reserved(u64 start, u64 end, unsigned not_used)
> return mcfg_res.flags;
> }
>
> -typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned type);
> +typedef bool (*check_reserved_t)(u64 start, u64 end, unsigned int type);
>
> static bool __ref is_mmconf_reserved(check_reserved_t is_reserved,
> struct pci_mmcfg_region *cfg,
>
> base-commit: 9e6a39eae450b81c8b2c8cbbfbdf8218e9b40c81
>

--
~Randy