Re: [PATCH net-next] net: mvneta: Fix validation of 2.5G HSGMII without comphy

Marek Behún
2020-11-15T08:56:24Z

On Sun, 15 Nov 2020 01:41:51 +0100
Andreas Färber <afaerber@suse.de> wrote:

> - if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX) {
> + if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX
> + || state->interface == PHY_INTERFACE_MODE_NA) {
> phylink_set(mask, 2500baseT_Full);
> phylink_set(mask, 2500baseX_Full);
> }

No, this will cause, on systems without comphy described, phylink to
think that 2500baseX/T is possible. But without comphy how can it be
configured?

Marek