From: Hui Su <sh_def@163.com>
To: christian.brauner@ubuntu.com, serge@hallyn.com,
avagin@openvz.org, 0x7f454c46@gmail.com,
linux-kernel@vger.kernel.org
Cc: sh_def@163.com
Subject: [PATCH] nsproxy: use put_nsproxy() in switch_task_namespaces()
Date: Mon, 16 Nov 2020 02:00:54 +0800 [thread overview]
Message-ID: <20201115180054.GA371317@rlk> (raw)
Use put_nsproxy() instead of '
if (atomic_dec_and_test(&ns->count)) {
free_nsproxy(ns);
}' in switch_task_namespaces().
and remove the whitespace by the way.
Signed-off-by: Hui Su <sh_def@163.com>
---
kernel/nsproxy.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
index 12dd41b39a7f..3ebfd090398a 100644
--- a/kernel/nsproxy.c
+++ b/kernel/nsproxy.c
@@ -173,7 +173,7 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
* it along with CLONE_NEWIPC.
*/
if ((flags & (CLONE_NEWIPC | CLONE_SYSVSEM)) ==
- (CLONE_NEWIPC | CLONE_SYSVSEM))
+ (CLONE_NEWIPC | CLONE_SYSVSEM))
return -EINVAL;
new_ns = create_new_namespaces(flags, tsk, user_ns, tsk->fs);
@@ -250,8 +250,8 @@ void switch_task_namespaces(struct task_struct *p, struct nsproxy *new)
p->nsproxy = new;
task_unlock(p);
- if (ns && atomic_dec_and_test(&ns->count))
- free_nsproxy(ns);
+ if (ns)
+ put_nsproxy(ns);
}
void exit_task_namespaces(struct task_struct *p)
--
2.29.0
next reply other threads:[~2020-11-15 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:00 Hui Su [this message]
2020-11-18 13:13 ` [PATCH] nsproxy: use put_nsproxy() in switch_task_namespaces() Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115180054.GA371317@rlk \
--to=sh_def@163.com \
--cc=0x7f454c46@gmail.com \
--cc=avagin@openvz.org \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox