Re: [PATCH v2 2/3] rtc: rx6110: add ACPI bindings to I2C

Andy Shevchenko
2020-11-17T11:11:28Z

On Tue, Nov 17, 2020 at 9:39 AM johannes-hahn@siemens.com
<johannes-hahn@siemens.com> wrote:
>
> Hello Andy,
>
> when comparing the ACPI IDs used in rtc-ds1307.c, which is already on mainline
>
> https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-ds1307.c#L1141
>
> for example. Every ID listed there is also not formatted the ACPI ID , PNP ID way defined in the ACPI spec.
>
> How about that ?

Bad examples should not prevent you from doing the right thing, correct?

JFYI: https://lore.kernel.org/linux-rtc/20201116142859.31257-1-andriy.shevchenko@linux.intel.com/

--
With Best Regards,
Andy Shevchenko