Re: [PATCH v2 1/3] rtc: rx6110: add i2c support

Andy Shevchenko
2020-11-16T14:43:01Z

On Thu, Nov 12, 2020 at 02:07:32PM +0100, Claudius Heine wrote:
> The RX6110 also supports I2C, so this patch adds support for it to the
> driver.
>
> This also renames the SPI specific functions and variables to include
> `_spi_` in their names.

As practice shows this is not the best approach. Can you ratqer split it to
three modules: core, spi, i2c like it's done in many other cases (esp. IIO)?

In Kconfig you just leave same option with two additional ones like

config ..._SPI
tristate
default SPI_MASTER
depends on SPI_MASTER

config ..._I2C
tristate
default I2C
depends on I2C

--
With Best Regards,
Andy Shevchenko