From: Mark Brown <broonie@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Tony Lindgren <tony@atomide.com>,
open list <linux-kernel@vger.kernel.org>,
Carl Philipp Klemm <philipp@uvos.xyz>,
Laxminath Kasam <lkasam@codeaurora.org>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack
Date: Mon, 16 Nov 2020 18:59:03 +0000 [thread overview]
Message-ID: <20201116185903.GD4739@sirena.org.uk> (raw)
In-Reply-To: <CAJ+vNU0T0qS282MU-FRy8zNLgjnvF=+-5k=XxxXhZw6k2cgASw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Fri, Nov 13, 2020 at 02:06:29PM -0800, Tim Harvey wrote:
> asserted? I'm also wondering if my issue is that I currently have the
> interrupt registered as such:
> ret = devm_regmap_add_irq_chip(dev, gsc->regmap, client->irq,
> IRQF_ONESHOT | IRQF_SHARED | IRQF_TRIGGER_FALLING, 0, &gsc_irq_chip,
> &irq_data);
> Perhaps this should be IRQF_TRIGGER_LOW as the device will not
> de-assert its IRQ# until all source bits are cleared.
That's clearly an active low interrupt, it will break things if it's
registered as edge triggered.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-16 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 17:06 [PATCH] mfd: cpcap: Fix interrupt regression with regmap clear_ack Tony Lindgren
2020-11-13 10:21 ` Lee Jones
2020-11-13 22:06 ` Tim Harvey
2020-11-15 8:43 ` Tony Lindgren
2020-11-16 20:45 ` Tim Harvey
2020-11-16 18:59 ` Mark Brown [this message]
2020-11-16 20:43 ` Tim Harvey
2020-11-16 21:14 ` Mark Brown
2020-11-15 17:31 ` Pavel Machek
2020-11-17 8:25 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116185903.GD4739@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkasam@codeaurora.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=sre@kernel.org \
--cc=tharvey@gateworks.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox