From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1932C2D0E4 for ; Tue, 17 Nov 2020 09:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B8452463C for ; Tue, 17 Nov 2020 09:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727028AbgKQJOu (ORCPT ); Tue, 17 Nov 2020 04:14:50 -0500 Received: from elvis.franken.de ([193.175.24.41]:37803 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgKQJOu (ORCPT ); Tue, 17 Nov 2020 04:14:50 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kex4Z-0008Mm-00; Tue, 17 Nov 2020 10:14:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id C1F11C0206; Tue, 17 Nov 2020 10:13:56 +0100 (CET) Date: Tue, 17 Nov 2020 10:13:56 +0100 From: Thomas Bogendoerfer To: Mike Rapoport Cc: Serge Semin , Andrew Morton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: kernel: Fix for_each_memblock conversion Message-ID: <20201117091356.GA7572@alpha.franken.de> References: <20201116174516.144243-1-tsbogend@alpha.franken.de> <20201116200554.rhbyvfmdzmchwwbs@mobilestation> <20201117080518.GH370813@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117080518.GH370813@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 10:05:18AM +0200, Mike Rapoport wrote: > On Mon, Nov 16, 2020 at 11:05:54PM +0300, Serge Semin wrote: > > On Mon, Nov 16, 2020 at 06:45:15PM +0100, Thomas Bogendoerfer wrote: > > > The loop over all memblocks works with PFN numbers and not physical > > > addresses, so we need for_each_mem_pfn_range(). > > > > Great catch! Don't know how that has been working so far. Anyway > > The loop is relevant only for systems with highmem, apparently there are > not many highmem users out there. I found the bug on a SGI IP22 probably because PHYS_OFFSET is != 0. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]