From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA5CC63777 for ; Tue, 17 Nov 2020 21:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FCC3221F9 for ; Tue, 17 Nov 2020 21:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fw8CVPuv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727916AbgKQVfc (ORCPT ); Tue, 17 Nov 2020 16:35:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726136AbgKQVfb (ORCPT ); Tue, 17 Nov 2020 16:35:31 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48FBFC0613CF for ; Tue, 17 Nov 2020 13:35:30 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id s2so10985731plr.9 for ; Tue, 17 Nov 2020 13:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gSJAJ0syJ78ceQy1Qt69nKgwbCK+98QEcAmwRhmUS6I=; b=Fw8CVPuv3WSulGgeIvke7FvfGyv4j7XsSyRpRrl0+o6ooEZ5zQKMLSzwMCEOKUmxfV vs8ey5SnHNEIUg/bjL6fuop2b0t++d76z7dKOaPsO/LXF1p03AXVP+dCkslM6RmIIu+U 1Owu941fcpsgxcmT4PCrI2svnGrrTl22XAYuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gSJAJ0syJ78ceQy1Qt69nKgwbCK+98QEcAmwRhmUS6I=; b=BVofNgHUeup6PS26ig6lKDlaMyqLG0By3uhlpPNF/8LnVnvUD7hvbZKCGyovNE3xGz gsrUgnK3f2hvz6RF81EVn1xszXRXrbOHxbBfpaWVQ5g9/UqYJTDZsuxGKEY+zK2WZwBd Sm5Cyni1RQS5btjDL97zmOMazdHAmOw8IzORODLJgwzwTt7czHszJW3+XRQndI5Mrmk3 tKVSdv6rZs0epAtx37W8fNrwyZpea/8EAQiQZ05HGafZDsX5Tw6Hm+0O/+EhPSIMVbkd t6ySopouo06Q896+s+0CNV+56Qey7m2nb6MBc+tuiewa6AIPn35ITwmoXoC0SdZ23dPd nWkA== X-Gm-Message-State: AOAM531CMyDWmJ5hoBe5LhVoiNSF1ChdUoMNvNhJLEuQMyNmnpDFYBBF 6l6hDO/yy8qv+ey5xw23CJGaHw== X-Google-Smtp-Source: ABdhPJzMbIdMxFceKu6lEVYMeH3xn+oN79t5xAiO7CYbUlREKo0ytHl7RiuOiEsNoLoPWPKMfurq2g== X-Received: by 2002:a17:902:6803:b029:d6:cf9d:2cfb with SMTP id h3-20020a1709026803b02900d6cf9d2cfbmr1396513plk.55.1605648929916; Tue, 17 Nov 2020 13:35:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id v19sm19389732pgi.2.2020.11.17.13.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:35:29 -0800 (PST) Date: Tue, 17 Nov 2020 13:35:28 -0800 From: Kees Cook To: John Paul Adrian Glaubitz Cc: linux-kernel@vger.kernel.org, Michael Karcher , Rich Felker , Andy Lutomirski , Will Drewry , linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests/seccomp: sh: Fix register names Message-ID: <202011171334.3F1BDC484@keescook> References: <20201117205656.1000223-1-keescook@chromium.org> <921a7e36-8b58-4a59-029a-066f5a05859e@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <921a7e36-8b58-4a59-029a-066f5a05859e@physik.fu-berlin.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 10:08:13PM +0100, John Paul Adrian Glaubitz wrote: > Hi Kees! > > On 11/17/20 9:56 PM, Kees Cook wrote: > > It looks like the seccomp selftests were never actually built for sh. > > This fixes it, though I don't have an environment to do a runtime test > > of it yet. > > We were testing libsecomp itself but I think we might have forgotten the > self-test. Not sure how these are run. If you're building natively, you can just build and run: cd tools/testing/selftests/seccomp make ./seccomp_bpf -- Kees Cook