From: Andrew Lunn <andrew@lunn.ch>
To: Bjarni Jonasson <bjarni.jonasson@microchip.com>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink
Date: Tue, 17 Nov 2020 14:45:46 +0100 [thread overview]
Message-ID: <20201117134546.GA1797886@lunn.ch> (raw)
In-Reply-To: <877dqkqly5.fsf@microchip.com>
> > Do you have the Marvell PHY driver either built-in or available as a
> > module? I suspect the problem is you don't. You will need the Marvell
> > PHY driver to correctly drive the PHY, you can't rely on the fallback
> > driver for SFPs.
> Correct. I was using the generic driver and that does clearly not
> work. After including the Marvell driver the callback to the validate
> function happens as expected. Thanks for the support.
Hi Russell
Maybe we should have MDIO_I2C driver select the Marvell PHY driver?
Andrew
next prev parent reply other threads:[~2020-11-17 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 10:06 [PATCH] phy: phylink: Fix CuSFP issue in phylink Bjarni Jonasson
2020-11-10 10:25 ` Russell King - ARM Linux admin
2020-11-10 14:16 ` Bjarni Jonasson
2020-11-10 15:12 ` Russell King - ARM Linux admin
2020-11-11 8:52 ` Bjarni Jonasson
2020-11-15 12:19 ` Russell King - ARM Linux admin
2020-11-17 11:09 ` Bjarni Jonasson
2020-11-17 13:45 ` Andrew Lunn [this message]
2020-11-17 15:08 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117134546.GA1797886@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox