Re: [PATCH][next] nfp: tls: Fix unreachable code issue

Jakub Kicinski
2020-11-18T18:49:02Z

On Tue, 17 Nov 2020 21:06:47 +0100 Simon Horman wrote:
> On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote:
> > Fix the following unreachable code issue:
> >
> > drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add':
> > include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable]
> > 208 | # define fallthrough __attribute__((__fallthrough__))
> > | ^~~~~~~~~~~~~
> > drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough'
> > 299 | fallthrough;
> > | ^~~~~~~~~~~
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Reviewed-by: Simon Horman <simon.horman@netronome.com>

Applied, thanks!